From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size
Date: Mon, 23 Nov 2015 09:03:58 -0700 [thread overview]
Message-ID: <565338EE.5070309@redhat.com> (raw)
In-Reply-To: <56532242.9040508@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On 11/23/2015 07:27 AM, Paolo Bonzini wrote:
>
>
> On 20/11/2015 18:32, Eric Blake wrote:
>>> static void qlist_size_iter(QObject *obj, void *opaque)
>>> {
>>> size_t *count = opaque;
>>> (*count)++;
>>> }
>>
>> Yuck - we don't track size independently? Seems like it might make a
>> worthwhile addition,
>
> Would you change your mind, if I told you that qlist_size is unused? :)
Deleting dead code is a perfectly acceptable alternative to advertising
what should normally be an O(1) operation with an O(n) implementation. :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-23 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 15:29 [Qemu-devel] [PATCH v2 0/4] json-streamer: Fix up code to limit nesting and size Markus Armbruster
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 1/4] json-streamer: Apply nesting limit more sanely Markus Armbruster
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 2/4] json-streamer: Don't crash when input exceeds nesting limit Markus Armbruster
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 3/4] check-qjson: Add test for JSON nesting depth limit Markus Armbruster
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size Markus Armbruster
2015-11-19 22:01 ` Paolo Bonzini
2015-11-20 6:13 ` Markus Armbruster
2015-11-20 8:50 ` Paolo Bonzini
2015-11-20 17:32 ` Eric Blake
2015-11-23 14:27 ` Paolo Bonzini
2015-11-23 16:03 ` Eric Blake [this message]
2015-11-23 17:09 ` Markus Armbruster
2015-11-19 16:15 ` [Qemu-devel] [PATCH v2 0/4] json-streamer: Fix up code to limit nesting and size Eric Blake
2015-11-19 16:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565338EE.5070309@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).