From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0tb1-0003Mq-WE for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:04:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0tay-0008I8-Nt for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:04:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0tay-0008Hd-J5 for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:04:00 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id A6B9EA3263 for ; Mon, 23 Nov 2015 16:03:59 +0000 (UTC) References: <1447946948-12489-1-git-send-email-armbru@redhat.com> <1447946948-12489-5-git-send-email-armbru@redhat.com> <564E46AD.4030901@redhat.com> <87egflqjty.fsf@blackfin.pond.sub.org> <564EDEE3.80000@redhat.com> <564F592D.4080305@redhat.com> <56532242.9040508@redhat.com> From: Eric Blake Message-ID: <565338EE.5070309@redhat.com> Date: Mon, 23 Nov 2015 09:03:58 -0700 MIME-Version: 1.0 In-Reply-To: <56532242.9040508@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9g9OJhG1UpOpsh9hOlfhkU421aNMEo1W9" Subject: Re: [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9g9OJhG1UpOpsh9hOlfhkU421aNMEo1W9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/23/2015 07:27 AM, Paolo Bonzini wrote: >=20 >=20 > On 20/11/2015 18:32, Eric Blake wrote: >>> static void qlist_size_iter(QObject *obj, void *opaque) >>> { >>> size_t *count =3D opaque; >>> (*count)++; >>> } >> >> Yuck - we don't track size independently? Seems like it might make a >> worthwhile addition, >=20 > Would you change your mind, if I told you that qlist_size is unused? :)= Deleting dead code is a perfectly acceptable alternative to advertising what should normally be an O(1) operation with an O(n) implementation. :)= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9g9OJhG1UpOpsh9hOlfhkU421aNMEo1W9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWUzjuAAoJEKeha0olJ0NqkogH/0PTI+0nPYWB1pJW10ziVIUf jiHdgBb1s+dkzvF92ecExgGAPPMlouDykYkSgPmile6PhYt7OkHsVlpmGAjnQgmf eU8griAeYzX3mpxuKQrvRUGI1CRjiToPp7CraJhW248pETkYGOL9X8DXzhpPKs3v 2jMdULh15+lOodeeJuuXFZOWH4VhhLVgQYz/1A/ESouwX6tqtJXuBvqQxFo4ZjyD BGLcfGzAnfs+gno4gXcTUwPYHsR5RHXc4qyf/t2VaEQfX/AYdLG+851BDuuyydAG ES9UpfHhokF6v4NrUYQQ2a+rmpEXcN/UxOVgdIx1uqfTMS7r6rUfLGgv/xYpgtk= =eN2y -----END PGP SIGNATURE----- --9g9OJhG1UpOpsh9hOlfhkU421aNMEo1W9--