From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0uOn-0004Si-7d for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:55:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0uOj-00048u-Tl for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:55:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0uOj-00048i-Ou for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:55:25 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5CB3C32D3B9 for ; Mon, 23 Nov 2015 16:55:25 +0000 (UTC) References: <1448282346-11626-1-git-send-email-kwolf@redhat.com> <1448282346-11626-2-git-send-email-kwolf@redhat.com> <565326AF.2080605@redhat.com> <20151123160947.GE4742@noname.str.redhat.com> From: Paolo Bonzini Message-ID: <565344F3.2040401@redhat.com> Date: Mon, 23 Nov 2015 17:55:15 +0100 MIME-Version: 1.0 In-Reply-To: <20151123160947.GE4742@noname.str.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] tests/Makefile: Add more dependencies for test-timed-average List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 23/11/2015 17:09, Kevin Wolf wrote: > Am 23.11.2015 um 15:46 hat Paolo Bonzini geschrieben: >> On 23/11/2015 13:39, Kevin Wolf wrote: >>> tests/test-timed-average$(EXESUF): tests/test-timed-average.o qemu-timer.o \ >>> libqemuutil.a stubs/clock-warp.o stubs/cpu-get-icount.o \ >>> - stubs/notify-event.o stubs/replay.o >>> + stubs/notify-event.o stubs/replay.o stubs/mon-is-qmp.o stubs/fd-register.o \ >>> + stubs/mon-printf.o >>> >> >> Why not just add libqemustub.a? (If it works, do not even bother >> reposting). > > Didn't remember that that's a thing and didn't check because the rule > already pulled in a few stubs manually. I'll go with the version below > then. (And given that you only gave an R-b, I guess I should take this > through my tree?) Yes please, they are block layer tests. Paolo > Kevin > > > diff --git a/tests/Makefile b/tests/Makefile > index b937984..0ef00a1 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -415,8 +415,7 @@ tests/test-vmstate$(EXESUF): tests/test-vmstate.o \ > migration/qemu-file-unix.o qjson.o \ > $(test-qom-obj-y) > tests/test-timed-average$(EXESUF): tests/test-timed-average.o qemu-timer.o \ > - libqemuutil.a stubs/clock-warp.o stubs/cpu-get-icount.o \ > - stubs/notify-event.o stubs/replay.o > + $(test-util-obj-y) > > tests/test-qapi-types.c tests/test-qapi-types.h :\ > $(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json $(SRC_PATH)/scripts/qapi-types.py $(qapi-py) >