From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1a13w2-0007Lc-Iu
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 22:06:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1a13vz-0004wr-DB
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 22:06:26 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:37919)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1a13vy-0004wk-Om
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 22:06:23 -0500
References: <1445503751-19912-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<87k2pfpol4.fsf@emacs.mitica>
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
Message-ID: <5653D40F.1090406@huawei.com>
Date: Tue, 24 Nov 2015 11:05:51 +0800
MIME-Version: 1.0
In-Reply-To: <87k2pfpol4.fsf@emacs.mitica>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] migration: Add state records for migration
	incoming
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: amit.shah@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, qemu-devel@nongnu.org

On 2015/11/18 18:51, Juan Quintela wrote:
> zhanghailiang <zhang.zhanghailiang@huawei.com> wrote:
>> For migration destination, sometimes we need to know its state,
>> and it is also useful for tracing migration incoming process.
>>
>> Here we add a new member 'state' for MigrationIncomingState,
>> and also use migrate_set_state() to modify its value.
>> We fix the first parameter of migrate_set_state(), and make it
>> public.
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
Hi Juan,

Thanks for your reply.

> 1st: split the patch about the change in migrate_set_state prototype,
> and the rest.
>

OK, i will do it in next version.

> Once there, if we are going to do this, at least show it on info migrate
> on destination?
>

I don't know if there is any sense to export migration info in destination.
In actual application, we use libvirt to issue migration command and get
migration info in source side. So it seems unnecessary to export them.

For COLO, we only use the state internally, to indicate whether we are in COLO state.

Thanks,
zhanghailiang

> If we are going this way, I think it is going to be better to reuse
> MigrationState?  That way, we could make the info migrate statistics
> easier to understand?
>
> Thanks, Juan.
>
> .
>