From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a19NM-0000jm-3T
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 03:55:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a19NH-0008DJ-4V
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 03:55:00 -0500
Received: from mx2.parallels.com ([199.115.105.18]:33821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a19NG-0008Cz-V0
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 03:54:55 -0500
References: <1447935637-19262-1-git-send-email-den@openvz.org>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <565425CA.40508@openvz.org>
Date: Tue, 24 Nov 2015 11:54:34 +0300
MIME-Version: 1.0
In-Reply-To: <1447935637-19262-1-git-send-email-den@openvz.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for 2.5 1/1] qga: gspawn() console helper
 to Windows guest agent msi build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: Yuri Pudgorodskiy <yur@virtuozzo.com>, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

On 11/19/2015 03:20 PM, Denis V. Lunev wrote:
> From: Yuri Pudgorodskiy <yur@virtuozzo.com>
>
> This helper, gspawn-win64-helper-console.exe for 64-bit and
> gspawn-win32-helper-console.exe for 32-bit environment,
> is needed for gspawn() mingw implementation, used by guest-exec command.
>
> Without these files guest-exec command on Windows will not
> work with "file not found" diagnostic message.
>
> Signed-off-by: Yuri Pudgorodskiy <yur@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>   qga/installer/qemu-ga.wxs | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
> index 6804f02..f25afdd 100644
> --- a/qga/installer/qemu-ga.wxs
> +++ b/qga/installer/qemu-ga.wxs
> @@ -91,6 +91,16 @@
>               <File Id="qga_vss.tlb" Name="qga-vss.tlb" Source="$(env.BUILD_DIR)/qga/vss-win32/qga-vss.tlb" KeyPath="yes" DiskId="1"/>
>             </Component>
>             <?endif?>
> +          <?if $(var.Arch) = "32"?>
> +          <Component Id="gspawn-helper-console" Guid="{446185B3-87BE-43D2-96B8-0FEFD9E8696D}">
> +            <File Id="gspawn-win32-helper-console.exe" Name="gspawn-win32-helper-console.exe" Source="$(var.Mingw_bin)/gspawn-win32-helper-console.exe" KeyPath="yes" DiskId="1"/>
> +          </Component>
> +          <?endif?>
> +          <?if $(var.Arch) = "64"?>
> +          <Component Id="gspawn-helper-console" Guid="{9E615A9F-349A-4992-A5C2-C10BAD173660}">
> +            <File Id="gspawn-win64-helper-console.exe" Name="gspawn-win64-helper-console.exe" Source="$(var.Mingw_bin)/gspawn-win64-helper-console.exe" KeyPath="yes" DiskId="1"/>
> +          </Component>
> +          <?endif?>
>             <Component Id="iconv" Guid="{35EE3558-D34B-4F0A-B8BD-430FF0775246}">
>               <File Id="iconv.dll" Name="iconv.dll" Source="$(var.Mingw_bin)/iconv.dll" KeyPath="yes" DiskId="1"/>
>             </Component>
> @@ -148,6 +158,7 @@
>         <ComponentRef Id="qga_vss_dll" />
>         <ComponentRef Id="qga_vss_tlb" />
>         <?endif?>
> +      <ComponentRef Id="gspawn-helper-console" />
>         <ComponentRef Id="iconv" />
>         <ComponentRef Id="libgcc_arch_lib" />
>         <ComponentRef Id="libglib" />
ping