From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Hnr-0004s3-Ea for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:54:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1Hnn-0003T3-Ac for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:54:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Hnn-0003Sa-3k for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:54:51 -0500 References: <144838492534.3052.2948919558518613064.stgit@localhost> <144838494386.3052.2385226717619371988.stgit@localhost> From: Eric Blake Message-ID: <5654A469.8080202@redhat.com> Date: Tue, 24 Nov 2015 10:54:49 -0700 MIME-Version: 1.0 In-Reply-To: <144838494386.3052.2385226717619371988.stgit@localhost> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VvsovesiD4O8o7lVBRRDDOXmbH7t0V8oe" Subject: Re: [Qemu-devel] [PATCH v2 03/10] trace: [tcg] Identify events with the 'vcpu' property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Eduardo Habkost , Stefan Hajnoczi , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VvsovesiD4O8o7lVBRRDDOXmbH7t0V8oe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2015 10:09 AM, Llu=C3=ADs Vilanova wrote: > A separate ID space ('TRACE_CPU_*') is used in attribute 'cpu_id' that > only contains events with the 'vcpu' property. >=20 > These are later used to select the appropriate physical TB cache based > on what events are active. >=20 > Signed-off-by: Llu=C3=ADs Vilanova > --- > +++ b/qapi/trace.json > @@ -1,6 +1,6 @@ > # -*- mode: python -*- > # > -# Copyright (C) 2011-2014 Llu=C3=ADs Vilanova > +# Copyright (C) 2011-2015 Llu=C3=ADs Vilanova > # > # This work is licensed under the terms of the GNU GPL, version 2 or l= ater. > # See the COPYING file in the top-level directory. > @@ -29,11 +29,12 @@ > # > # @name: Event name. > # @state: Tracing state. > +# @vcpu: Whether this is a per-vCPU event (since 2.5). You've missed 2.5 hard freeze; this will need to be 2.6. Also, I note that patch 9/10 touches the same line again to make it optional; why not just have it be optional in the beginning, to reduce churn within the series? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VvsovesiD4O8o7lVBRRDDOXmbH7t0V8oe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVKRpAAoJEKeha0olJ0NqEjYIALDFetjqLMwcOshiUWSLbh56 hPPbz4apXwJ/JtcHiWqREN2z+41R/t+5wvzkYw4pZTjZ1vQ8iCBnjWiLyYVYX9pO N3Lv5uoNTUYoVZKd4x5fNqKjKEkBRam3MzX1WPBTS8STL40pEgoJD8bnSmTQCTu3 q1HfjOcanVagntWf4pfJld4H1SgSFVFZYei+wOMw1QXsfiA7VsCH4Wpg5PK9ebH1 84L3IreaPm+zUW03P2cqiGyni0daJWNFdl2v++i3Vf3xc2LxImDLc/IGZYOsfNy3 WXxvwtNsfJ8uaZLlxaVR8+Fn4XY80QLg/RV/YKQ0fUlq7t9VKUzlJn7lXr/wnIc= =HMAl -----END PGP SIGNATURE----- --VvsovesiD4O8o7lVBRRDDOXmbH7t0V8oe--