Re: [Qemu-devel] [PATCH for-2.5] eepro100: Prevent two endless loops

[Jason Wang <jasowang@redhat.com>]

On 11/20/2015 07:27 PM, P J P wrote:
> +-- On Fri, 20 Nov 2015, Stefan Weil wrote --+
> | include/hw/pci/pci.h:    static inline uint##_bits##_t
> | ld##_l##_pci_dma(PCIDevice *dev,      \
>
>    I see.
>  
> | Is there an ideal count? If it is too low, it might break some use cases.
> | If it is too high, it will take longer until the loop is finished.
>
>   -> https://url.corp.redhat.com/8255x-manual-pdf
>
>   I tried to look trough the 8255x manual above, it does not have a specific 
> value for the count, as it's a linked list of command blocks.
>
>  
> | I don't think EEPRO100 emulation is used in critical production 
> | applications. Therefore a lower value and a debug message when this value is 
> | exceeded might be helpful to find out which lowest value is acceptable. If 
> | you want to avoid this risk, the value should be set to 256, 10000, 65536 or 
> | any other higher value. Feel free to change this when you apply the patch.
>
>   I guess Jason would be best to decide that.
>
>
> Thank you.
> --
>  - P J P
> 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
>

Apply the patch as is. We could enlarge the limitation if we find it was
too small in the future.

Thanks