From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1QRq-0006Wp-OI for qemu-devel@nongnu.org; Tue, 24 Nov 2015 22:08:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1QRn-0001Vl-IR for qemu-devel@nongnu.org; Tue, 24 Nov 2015 22:08:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1QRn-0001Vh-Cx for qemu-devel@nongnu.org; Tue, 24 Nov 2015 22:08:43 -0500 References: <1448005353-16007-1-git-send-email-sw@weilnetz.de> <564EDF60.7080305@weilnetz.de> From: Jason Wang Message-ID: <56552634.9060805@redhat.com> Date: Wed, 25 Nov 2015 11:08:36 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5] eepro100: Prevent two endless loops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: P J P , Stefan Weil Cc: Peter Maydell , QEMU Developer On 11/20/2015 07:27 PM, P J P wrote: > +-- On Fri, 20 Nov 2015, Stefan Weil wrote --+ > | include/hw/pci/pci.h: static inline uint##_bits##_t > | ld##_l##_pci_dma(PCIDevice *dev, \ > > I see. > > | Is there an ideal count? If it is too low, it might break some use cases. > | If it is too high, it will take longer until the loop is finished. > > -> https://url.corp.redhat.com/8255x-manual-pdf > > I tried to look trough the 8255x manual above, it does not have a specific > value for the count, as it's a linked list of command blocks. > > > | I don't think EEPRO100 emulation is used in critical production > | applications. Therefore a lower value and a debug message when this value is > | exceeded might be helpful to find out which lowest value is acceptable. If > | you want to avoid this risk, the value should be set to 256, 10000, 65536 or > | any other higher value. Feel free to change this when you apply the patch. > > I guess Jason would be best to decide that. > > > Thank you. > -- > - P J P > 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F > Apply the patch as is. We could enlarge the limitation if we find it was too small in the future. Thanks