From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Vrt-0004gC-4V for qemu-devel@nongnu.org; Wed, 25 Nov 2015 03:56:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1Vro-0002bU-2f for qemu-devel@nongnu.org; Wed, 25 Nov 2015 03:56:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:56296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Vrn-0002bO-Se for qemu-devel@nongnu.org; Wed, 25 Nov 2015 03:55:56 -0500 Message-ID: <56557799.3030703@suse.de> Date: Wed, 25 Nov 2015 09:55:53 +0100 From: Hannes Reinecke MIME-Version: 1.0 References: <1447684618-17794-1-git-send-email-hare@suse.de> <1447684618-17794-4-git-send-email-hare@suse.de> <20151125075557.GC7357@stefanha-x1.localdomain> In-Reply-To: <20151125075557.GC7357@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Implement 'REPORT TARGET PORT GROUPS' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Johannes Thumshirn , Paolo Bonzini , qemu-devel@nongnu.org, Alexander Graf -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/25/2015 08:55 AM, Stefan Hajnoczi wrote: > On Mon, Nov 16, 2015 at 03:36:58PM +0100, Hannes Reinecke > wrote: >> + /* Enable TGPS bit */ + if (s->wwn) + >> outbuf[4] =3D 1; >=20 > QEMU coding style: Please always use curly braces, even if the > if statement body is just one line. >=20 Yeah, will be doing so on the next round. >> +static void qdev_enumerate_port_group(PortGroupEnumerate >> *pg, DeviceState *dev) +{ + BusState *child; + + if >> (!strcmp(object_get_typename(OBJECT(dev->parent_bus)), >> TYPE_SCSI_BUS)) { >=20 > object_dynamic_cast(OBJECT(dev->parent_bus), TYPE_SCSI_BUS) is > shorter and doesn't require the explicit strcmp(). >=20 The ever-changing qemu infrastructure ... yeah, will be fixing it up. >> +static int >> scsi_emulate_report_target_port_groups(SCSIDiskState *s, >> uint8_t *inbuf) >=20 > "inbuf" seems to be an output buffer rather than an input > buffer. The name "outbuf" would be clearer. >=20 > How does this function protect against buffer overflow? It's > not obvious how we guarantee the output buffer is large > enough. >=20 Good question; will have to check. Cheers, Hannes - --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWVXeZAAoJEGz4yi9OyKjP2yAQAIENfXolPp+Q6BsWyHEbinMn P/Z+HlgEZE+fSP8qq4F4txzB/0FUpiuvonKTzJmC41izhXLGDs6vFPNH9CX7bNob PmbWD7ZXVVJdEX8xpmJRNKN1XfIFcwHVE51FNqM62OggfMZx4XW3zZ9scpzEjaW0 70l1q7FEn+sg7BsE4aH11+fhdAdQaEo3G2tx8g6X2uleiNC0NJWIR7XyFJOl68wY plmfotRgpX6x7vNKkge5EyMEBhpoltql8K6IsAJfWQlHIWduErGIXmCuaDdz1Whh aLsfLNajG5CB7gZddu+XsIVlbujHqoTn26UTtPC8dL20w1S7wv/TaYnKLchRCn+5 UydjjI1AdB9EKqhQUGI6itGT+GDE/Rf3vDHzdUmZou4u/U3kuhWlupaCTGqLKpvA HHOMi0EAqQrM30kYWX4jKhTSAP5Y8GKFQhBxVi7Y9pZSYWHIoMLg/LbKpFx97rN6 iSOkq9KYBJH+rgS5tBiHCTCYjrlbvHV5UiGVt2/Q0WjeRx0kMPLnLA1fGsiubnjs ZjqpuIih72GTSSSzrvNPcpL4RmDWwXoh0UtamSs7jBMa/Gto8m0cHWxeaiJ3vxgC E5EgxycmX81/smvq+kdre8XhECDYulyXffZxQWsZqsDChwFB+9OFL523bpZm1Pu4 +pqGLkHyVZPeQUCV1MWC =3Db3kw -----END PGP SIGNATURE-----