From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bmo-0003KA-0c for qemu-devel@nongnu.org; Wed, 25 Nov 2015 10:15:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1bmj-0005JJ-P9 for qemu-devel@nongnu.org; Wed, 25 Nov 2015 10:15:09 -0500 References: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> <20151109084731.GH18558@voom.redhat.com> <564C2CA3.8000307@ozlabs.ru> <20151118104927.GA3298@voom.fritz.box> From: Alexander Graf Message-ID: <5655D075.9020609@suse.de> Date: Wed, 25 Nov 2015 16:15:01 +0100 MIME-Version: 1.0 In-Reply-To: <20151118104927.GA3298@voom.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Add /system-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 18.11.15 11:49, David Gibson wrote: > On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashevskiy wrote: >> On 11/09/2015 07:47 PM, David Gibson wrote: >>> On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote: >>>> Section B.6.2.1 Root Node Properties of PAPR specification defines >>>> a set of properties which shall be present in the device tree root, >>>> one of these properties is "system-id" which "should be unique across >>>> all systems and all manufacturers". Since UUID is meant to be unique, >>>> it makes sense to use it as "system-id". >>>> >>>> This adds "system-id" property to the device tree root when not empty. >>>> >>>> Signed-off-by: Alexey Kardashevskiy >>>> --- >>>> >>>> This might be expected by AIX so here is the patch. >>>> I am really not sure if it makes sense to initialize property when >>>> UUID is all zeroes as the requirement is "unique" and zero-uuid is >>>> not. >>> >>> Yeah, I think it would be better to omit system-id entirely when a >>> UUID hasn't been supplied. >> >> >> so this did not go anywhere yet, did it? > > No. So where is it stuck? Alex