From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dau-00072p-7n for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:11:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1daq-0005P0-UE for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:11:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1daq-0005OP-PR for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:10:56 -0500 References: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com> <1448456352-14143-3-git-send-email-marcandre.lureau@redhat.com> <5655DBAF.3040506@redhat.com> <20151125162102.6284.38229@loki> <5655E4BF.3010604@redhat.com> <20151125164608.6284.38856@loki> From: Eric Blake Message-ID: <5655EB96.2090200@redhat.com> Date: Wed, 25 Nov 2015 10:10:46 -0700 MIME-Version: 1.0 In-Reply-To: <20151125164608.6284.38856@loki> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i2nIcFDILI28iuuJivc7WShC1NJpItWnJ" Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i2nIcFDILI28iuuJivc7WShC1NJpItWnJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2015 09:46 AM, Michael Roth wrote: > Quoting Eric Blake (2015-11-25 10:41:35) >> On 11/25/2015 09:21 AM, Michael Roth wrote: >> >>>>> + /* seek to 0 */ >>>>> + cmd =3D g_strdup_printf("{'execute': 'guest-file-seek'," >>>>> + " 'arguments': { 'handle': %" PRId64 ", = " >>>>> + " 'offset': %d, 'whence': %d } }", >>>>> + id, 0, SEEK_SET); >>>> >>>> We still have a conflict between this series and my proposal to codi= fy 0 >>>> rather than relying on platform-specific SEEK_SET; Markus had the >>>> suggestion of using QGA_SET (or QGA_SEEK_SET). Are we trying to get= >>>> both your series and my v2 patch into 2.5? Knowing that will help m= e >>>> decide whether my v2 should be rebased on top of your patches. >>> >>> I was planning on pulling in your patch on top of this for the next >>> 2.5 pull, so rebasing on top of this series is probably best. >> >> Okay, will do, and will do quickly so I'm not holding up your pull req= uest. >=20 > Thanks! FYI I now have this series applied here if you'd like to base > on that: >=20 > https://github.com/mdroth/qemu/commits/qga On that branch, commit 7a38932 has two typos: s/is commit msg (Lazlo)/in commit msg (Laszlo)/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --i2nIcFDILI28iuuJivc7WShC1NJpItWnJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVeuWAAoJEKeha0olJ0Nq5gAH/RgCRWgGvbt2VtPr/ox7hxDa TPTPR3c/ebq6tlibno/hEAIow4Bx7lmWdmj9dY5Xzm2a444sVV6oQIdNtDEJpOD+ X46rIui5Fa0LrAnfAsfB1bJio2NP2Sif0JydahFvywGjlbUxaJZ1cJu2LrRDYN4V YAJV/E4PN+CMTMROSgzvpDFdzu+opzvbRcx2jWpKoosAO0v4rF/JK2IE+ixR3vjt dZKSMD2CXgxKOA8U5ZVVvsWA9q7Y0wX5Bckx4OGAWNtlwRbRHe28gRzi7AIC/ztT yTcCBD3bHWpi4kEOPzwcqXu8YpRT3ISLg7P4h6ef+FyDGkV8rt12wbCkPrIu1J0= =W2Mi -----END PGP SIGNATURE----- --i2nIcFDILI28iuuJivc7WShC1NJpItWnJ--