From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dtm-0001Hc-Ok for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:30:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1dtj-0002Lr-03 for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:30:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dti-0002Lf-KR for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:30:26 -0500 References: <1448466589-9407-1-git-send-email-ehabkost@redhat.com> <1448466589-9407-2-git-send-email-ehabkost@redhat.com> <5655E5EE.8060906@redhat.com> <20151125172617.GS23717@thinpad.lan.raisama.net> From: Paolo Bonzini Message-ID: <5655F02C.5090306@redhat.com> Date: Wed, 25 Nov 2015 18:30:20 +0100 MIME-Version: 1.0 In-Reply-To: <20151125172617.GS23717@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] target-i386: kvm: Abort if MCE bank count is not supported by host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: kvm@vger.kernel.org, Marcelo Tosatti , qemu-devel@nongnu.org, Borislav Petkov , ying.huang@intel.com, =?UTF-8?Q?Andreas_F=c3=a4rber?= , Richard Henderson On 25/11/2015 18:26, Eduardo Habkost wrote: >> > Yoda conditions? >> > >> > if (banks < MCE_BANKS_DEF) { >> > error_report("kvm: Unsupported MCE bank count (QEMU = %d, KVM = %d)", >> > MCE_BANKS_DEF, banks); > This was on purpose, because MCE_BANKS_DEF is replaced by > (env->mcg_caps & MCG_CAPS_COUNT_MASK) in the next patch. Yeah, I noticed it later. Paolo