From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dtu-0001TT-IN for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:30:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1dtt-0002O4-Ua for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:30:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dtt-0002Nw-P6 for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:30:37 -0500 References: <1448466589-9407-1-git-send-email-ehabkost@redhat.com> <1448466589-9407-4-git-send-email-ehabkost@redhat.com> <5655E5A0.9030009@redhat.com> <20151125172925.GT23717@thinpad.lan.raisama.net> From: Paolo Bonzini Message-ID: <5655F038.50101@redhat.com> Date: Wed, 25 Nov 2015 18:30:32 +0100 MIME-Version: 1.0 In-Reply-To: <20151125172925.GT23717@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: kvm@vger.kernel.org, Marcelo Tosatti , qemu-devel@nongnu.org, Borislav Petkov , ying.huang@intel.com, =?UTF-8?Q?Andreas_F=c3=a4rber?= , Richard Henderson On 25/11/2015 18:29, Eduardo Habkost wrote: >>> > > >>> > > + unsupported_caps = env->mcg_cap & ~(mcg_cap | MCG_CAP_BANKS_MASK); >>> > > + if (unsupported_caps) { >>> > > + error_report("warning: Unsupported MCG_CAP bits: 0x%" PRIx64 "\n", >> > >> > \n should not be at end of error_report. >> > >> > Fixed and applied. > MCG_CAP_BANKS_MASK is defined by patch 2/3. Have you applied the > whole series? Yes, of course. Paolo