From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1eUq-0005cz-6n for qemu-devel@nongnu.org; Wed, 25 Nov 2015 13:08:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1eUm-0004Dk-Uf for qemu-devel@nongnu.org; Wed, 25 Nov 2015 13:08:48 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:34909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1eUm-0004Da-OS for qemu-devel@nongnu.org; Wed, 25 Nov 2015 13:08:44 -0500 Received: by wmuu63 with SMTP id u63so148631903wmu.0 for ; Wed, 25 Nov 2015 10:08:44 -0800 (PST) Sender: Paolo Bonzini References: <1448300659-23559-1-git-send-email-pbonzini@redhat.com> <87d1uy16hi.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <5655F929.3010804@redhat.com> Date: Wed, 25 Nov 2015 19:08:41 +0100 MIME-Version: 1.0 In-Reply-To: <87d1uy16hi.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for-2.5? 0/4] qjson: save a lot of memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 25/11/2015 15:47, Markus Armbruster wrote: > > This patch from 2011 (!) saves about 96% of the allocation cost (down > > from 500 MiB to 20 MiB) for check-qjson. > > Looks good to me apart from the incomplete transition to recursive > descent in PATCH 2. I do not understand whether that is a problem. Is the remark from the commit message incorrect ("Saving the parser context is mostly unnecessary; we can replace it with peeking at the next token, or remove it altogether when the restore only happens on errors. The token list is destroyed anyway on errors.")? Paolo