From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1i6o-0001yX-0y for qemu-devel@nongnu.org; Wed, 25 Nov 2015 17:00:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1i6k-0002lP-Rf for qemu-devel@nongnu.org; Wed, 25 Nov 2015 17:00:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1i6k-0002lF-MU for qemu-devel@nongnu.org; Wed, 25 Nov 2015 17:00:10 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 21948E7091 for ; Wed, 25 Nov 2015 22:00:10 +0000 (UTC) References: <1448486613-17634-1-git-send-email-armbru@redhat.com> <1448486613-17634-5-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56562F64.10102@redhat.com> Date: Wed, 25 Nov 2015 15:00:04 -0700 MIME-Version: 1.0 In-Reply-To: <1448486613-17634-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QpmU4GO014tcjkNGaapd5Xqp7owpMMbFL" Subject: Re: [Qemu-devel] [PATCH v3 for-2.5 04/12] qjson: Spell out some silent assumptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QpmU4GO014tcjkNGaapd5Xqp7owpMMbFL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2015 02:23 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/qapi/qmp/json-lexer.h | 3 ++- > qobject/json-lexer.c | 7 ++++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > =20 > +QEMU_BUILD_BUG_ON((int)JSON_MIN <=3D (int)IN_START); I see why the casts are needed here (otherwise, you are comparing two different enum types, which can trigger warnings). Perhaps one cast is sufficient, but using both is consistent. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QpmU4GO014tcjkNGaapd5Xqp7owpMMbFL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVi9kAAoJEKeha0olJ0Nqw4wH/2ieNv87OhfC6+tKSC9hFuh2 /sr6wT0dkYvjVmGCZg2KCYZaPknygcPFDTwEfzbG9EJuZLZk666DZxGZ3OgC2Aio p0LbBHNGRxKQLp/0+cVnfisLl3SdCK4MPBjQDdndM+MBDSYBc/Vx0fe80E3TAX/V p7NBHLFqbwq8bF5aZgAt5WnmhmJDo33NZDVrDCgDyxkWJLAPkmOP5yQobQSRV8DQ omloStynD4WiY/PiXCSBSRx0XOLpBpFUcV1fyyBRcfKjOOz3CTNHDVaQTkV7NQM9 /yrYHQmGma+0YFyiMNqSRpw+XDXj7kBOEaUqjlplA3odOI+w0OpaWACBo95tLc0= =bZHu -----END PGP SIGNATURE----- --QpmU4GO014tcjkNGaapd5Xqp7owpMMbFL--