Re: [Qemu-devel] [PATCH v3 for-2.5 11/12] qjson: surprise, allocating 6 QObjects per token is expensive

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

On 11/25/2015 02:23 PM, Markus Armbruster wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Replace the contents of the tokens GQueue with a simple struct.  This cuts
> the amount of memory allocated by tests/check-qjson from ~500MB to ~20MB,
> and the execution time from 600ms to 80ms on my laptop.  Still a lot (some
> could be saved by using an intrusive list, such as QSIMPLEQ, instead of
> the GQueue), but the savings are already massive and the right thing to
> do would probably be to get rid of json-streamer completely.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Message-Id: <1448300659-23559-5-git-send-email-pbonzini@redhat.com>
> [Straightforwardly rebased on my patches]
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/qapi/qmp/json-streamer.h |   7 +++
>  qobject/json-parser.c            | 115 ++++++++++++++++-----------------------
>  qobject/json-streamer.c          |  19 +++----
>  3 files changed, 63 insertions(+), 78 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]