From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1oxw-0007mk-Pg for qemu-devel@nongnu.org; Thu, 26 Nov 2015 00:19:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1oxv-0002Wx-Uw for qemu-devel@nongnu.org; Thu, 26 Nov 2015 00:19:32 -0500 References: <1448514335-15988-1-git-send-email-famz@redhat.com> <1448514335-15988-14-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <56569657.6090909@redhat.com> Date: Wed, 25 Nov 2015 22:19:19 -0700 MIME-Version: 1.0 In-Reply-To: <1448514335-15988-14-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VKFvftgLMANk7KVDjiXh6xKj8BjkehOGt" Subject: Re: [Qemu-devel] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Peter Lieven , Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VKFvftgLMANk7KVDjiXh6xKj8BjkehOGt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2015 10:05 PM, Fam Zheng wrote: > The "flags" bit mask is expanded to two booleans, "data" and "zero"; > "bs" is replaced with "filename" string. >=20 > Refactor the merge conditions in img_map() into entry_mergable(). s/mergable/mergeable/ here and in the patch body >=20 > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 27 ++++++++++++++++++++ > qemu-img.c | 71 +++++++++++++++++++++++++++++++-------------= -------- > 2 files changed, 69 insertions(+), 29 deletions(-) >=20 With the spelling fix, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VKFvftgLMANk7KVDjiXh6xKj8BjkehOGt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVpZXAAoJEKeha0olJ0NqVQoIAKgO1npU5rguJds1zPnPv6Sr V/RBvwYdMlWkzJkpKvRYvnzdzkYxYzhpiYLTt+akPRv8ya2Q2JjRbRlTgEMds0CC 9yhrikRKtaEG6sPzojn7rZu3RxjKJ1HD0iJIIUu+Gsw8fdbFQzCq29fehQA7XiGU 4GLuUS9wIyAaE05jrRtWpPldaBdM9tGtD7tEW68UinJ1kcRyW5hcXHqVjAooXTHm gBuIRAJuTelXxNrpNr2qnzc/BGymAI1BpzUGPWqsxupVRs3RHUlqnP1R8ekoQQAU drA4xSCzlfkSptZwVjKPAHwSr9yyAb0bJBm0StBDmf1rxr+IiRLP4NQkgobBMoI= =5X4f -----END PGP SIGNATURE----- --VKFvftgLMANk7KVDjiXh6xKj8BjkehOGt--