From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1p0N-0000OA-Al for qemu-devel@nongnu.org; Thu, 26 Nov 2015 00:22:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1p0M-0002p6-I4 for qemu-devel@nongnu.org; Thu, 26 Nov 2015 00:22:03 -0500 References: <1448514335-15988-1-git-send-email-famz@redhat.com> <1448514335-15988-13-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <565696F4.5040804@redhat.com> Date: Wed, 25 Nov 2015 22:21:56 -0700 MIME-Version: 1.0 In-Reply-To: <1448514335-15988-13-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RwMwEtq14bL2jlrMEfMftlsTp6K8oaS8m" Subject: Re: [Qemu-devel] [PATCH v3 12/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Peter Lieven , Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RwMwEtq14bL2jlrMEfMftlsTp6K8oaS8m Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2015 10:05 PM, Fam Zheng wrote: > Now all drivers should return a correct "file", we can make use of it, > even with the recursion into backing chain above. >=20 > Signed-off-by: Fam Zheng > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/qemu-img.c b/qemu-img.c > index 7954242..a7fa794 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -2222,7 +2222,7 @@ static int get_block_status(BlockDriverState *bs,= int64_t sector_num, > e->flags =3D ret & ~BDRV_BLOCK_OFFSET_MASK; > e->offset =3D ret & BDRV_BLOCK_OFFSET_MASK; > e->depth =3D depth; > - e->bs =3D bs; > + e->bs =3D file; > return 0; > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RwMwEtq14bL2jlrMEfMftlsTp6K8oaS8m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVpb0AAoJEKeha0olJ0NqQS4H+gLywZEoUIfkn2UkAWIeWZXz 9ZuVovnZgU1bTWndHPPL+47rHAwxYQOMaF5Vihzt1NNugc3GVwefSPJn2kn4zPoE W6mpJ/RaRg//Own2SCt35rR9G42OI5D46UCi/KfYJYttRVNXSu5ihAuoK4XUEO18 XQ8ePgp4GkNBKy9HIMAJiWlpuvvTKQ3VOcJqdk82O8eqGGBpM4wdbZGEmHPObsCn xghSkaI6lgl2LOIB4Ckt/h86ux5OlRjwaZuvzw3m+TKE2p2tYbLqCHggWeKXMU/j x2CBD+X7h6C1rMwd2UC5gAQNGNL23BuDuaecgOT9x6R/8V+PgOG1NvgS+rvjcN8= =SPon -----END PGP SIGNATURE----- --RwMwEtq14bL2jlrMEfMftlsTp6K8oaS8m--