From: David Engraf <david.engraf@sysgo.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized
Date: Thu, 26 Nov 2015 10:12:03 +0100 [thread overview]
Message-ID: <5656CCE3.2050504@sysgo.com> (raw)
In-Reply-To: <5655DEE2.20700@redhat.com>
Am 25.11.2015 um 17:16 schrieb Paolo Bonzini:
>
>
> On 25/11/2015 16:48, David Engraf wrote:
>>
>> Indeed, TLS handling is broken. The address of iothread_locked is always
>> the same between threads and I can see that a different thread sets
>> iothread_locked to false, thus my current thread uses an invalid state.
>> I will have to check why my compiler produces invalid TLS code.
>
> That rings a bell, I think there are different CRT libraries or
> something like that. Stefan, what would break TLS under Windows?
"--extra-cflags=-mthreads" is the solution. iothread_locked is unique
for each thread now. I saw that this is already mentioned in the
Documentation [1], but why isn't that enabled by default if QEMU
requires this option on Windows? Without this option, even the latest
version of gcc doesn't produce working TLS code.
Many thanks for your support!
David
[1] http://wiki.qemu.org/Hosts/W32
next prev parent reply other threads:[~2015-11-26 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 15:43 [Qemu-devel] [PATCH] qemu_mutex_iothread_locked not correctly synchronized David Engraf
2015-11-24 15:54 ` Paolo Bonzini
2015-11-25 9:08 ` David Engraf
2015-11-25 12:31 ` [Qemu-devel] [PATCH v2] " David Engraf
2015-11-25 13:26 ` Paolo Bonzini
2015-11-25 14:04 ` David Engraf
2015-11-25 14:36 ` Paolo Bonzini
2015-11-25 15:48 ` David Engraf
2015-11-25 16:16 ` Paolo Bonzini
2015-11-26 9:12 ` David Engraf [this message]
2015-11-26 11:25 ` Stefan Weil
2015-11-26 14:26 ` David Engraf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656CCE3.2050504@sysgo.com \
--to=david.engraf@sysgo.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).