From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1t3o-0003V9-Ul for qemu-devel@nongnu.org; Thu, 26 Nov 2015 04:41:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1t3n-0001Om-IN for qemu-devel@nongnu.org; Thu, 26 Nov 2015 04:41:52 -0500 Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:57351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1t3n-0001Oh-93 for qemu-devel@nongnu.org; Thu, 26 Nov 2015 04:41:51 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Nov 2015 09:41:47 -0000 References: <1448388091-117282-1-git-send-email-pbonzini@redhat.com> <5656D2B9.3010802@de.ibm.com> From: Christian Borntraeger Message-ID: <5656D3D6.1050906@de.ibm.com> Date: Thu, 26 Nov 2015 10:41:42 +0100 MIME-Version: 1.0 In-Reply-To: <5656D2B9.3010802@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 00/40] Sneak peek of virtio and dataplane changes for 2.6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: mlin@kernel.org, famz@redhat.com, ming.lei@canonical.com, stefanha@redhat.com, mst@redhat.com On 11/26/2015 10:36 AM, Christian Borntraeger wrote: > On 11/24/2015 07:00 PM, Paolo Bonzini wrote: >> This large series is basically all that I would like to get into 2.6. >> It is a combination of several pieces of work on dataplane and >> multithreaded block layer. >> >> It's also a large part of why I would like someone else to look at >> miscellaneous patches for a while (in case you've missed that). I >> can foresee that following the reviews is going to be a huge time drain. >> >> With it I can get ~1300 Kiops on 8 disks (which I achieve with 2 iothreads >> and 5 VCPUs). The bulk of the improvement actually comes from the first >> 8 patches, but the rest of the series is what prepares for what's next >> to come in QEMU 2.7 and later, such as a multiqueue block layer. >> >> It's tedious to review, with some pretty large patches (3, 32, 33, 35). > On 11/24/2015 07:00 PM, Paolo Bonzini wrote: >> This large series is basically all that I would like to get into 2.6. >> It is a combination of several pieces of work on dataplane and >> multithreaded block layer. >> >> It's also a large part of why I would like someone else to look at >> miscellaneous patches for a while (in case you've missed that). I >> can foresee that following the reviews is going to be a huge time drain. >> >> With it I can get ~1300 Kiops on 8 disks (which I achieve with 2 iothreads >> and 5 VCPUs). The bulk of the improvement actually comes from the first >> 8 patches, but the rest of the series is what prepares for what's next >> to come in QEMU 2.7 and later, such as a multiqueue block layer. > > For some unknown reason, this seems to be slightly slower than 2.5-rc1 on my > old z196. (have not net tested the z13) > > your branch is certainly better regarding malloc, but worse regarding others. Using the first 8 patches or so (commit be2f6b163e2b2a604f52a258fd932142c5974ffe vring: slim down allocation of VirtQueueElements) is slightly faster than 2.5.0-rc1, so the regression seems to come from some of the later patches.