From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1taO-0002c8-4R for qemu-devel@nongnu.org; Thu, 26 Nov 2015 05:15:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1taJ-0003yF-TN for qemu-devel@nongnu.org; Thu, 26 Nov 2015 05:15:32 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:42760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1taJ-0003y3-Nw for qemu-devel@nongnu.org; Thu, 26 Nov 2015 05:15:27 -0500 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Nov 2015 03:15:27 -0700 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 5254719D8026 for ; Thu, 26 Nov 2015 03:03:28 -0700 (MST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tAQAFLJ428442766 for ; Thu, 26 Nov 2015 03:15:21 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tAQAFKAm011517 for ; Thu, 26 Nov 2015 03:15:20 -0700 References: <1446604018-14025-1-git-send-email-tubo@linux.vnet.ibm.com> <1446604018-14025-3-git-send-email-tubo@linux.vnet.ibm.com> <564CACB1.5020806@redhat.com> <564D7A04.7090402@linux.vnet.ibm.com> <564F493C.3030501@redhat.com> <87d1uzdrn4.fsf@oc4731375738.ibm.com> <5655D6C7.5050903@redhat.com> From: tu bo Message-ID: <5656DBB5.7060207@linux.vnet.ibm.com> Date: Thu, 26 Nov 2015 18:15:17 +0800 MIME-Version: 1.0 In-Reply-To: <5655D6C7.5050903@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Sascha Silbe , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, mimu@linux.vnet.ibm.com Hi Max: On 11/25/2015 11:41 PM, Max Reitz wrote: > On 24.11.2015 22:17, Sascha Silbe wrote: >> This PC/s390x-only hunk looks like an oversight to me. > > Not really, see > http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg01906.html > and > http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02851.html > > I noticed, but I am fine with it since the tests probably won't run on > anything but x86/pc and s390 anyway (without modifications; most of the > changes this series is making to make the iotests work on s390 are > necessary for other non-pc platforms as well, and that shows to me that > apparently nobody tried to run the iotests on non-pc platforms before > s390, or didn't care enough about them to fix them). > >> We should make >> one of the options the default. I'd prefer defaulting to virtio (see >> below), but since the test previously hard-coded IDE that would be fine, >> too. > > In my first reply above, I noted that virtio0 may not be available on > all platforms either. Therefore, I'd rather have an explicit list of > platforms there than an asterisk where it does not belong. > > However, my second reply above spawned a bit of a discussion, where > Kevin simply proposed to change the ID of the drive to something known, > i.e. just set the ID by adding an id=drive0 or something to the -drive > parameter. > > Thanks for reminding me of the above, I had already forgotten. Indeed, > we should just add id=drive0 to the -drive parameter and use drive0. A > similar solution may be possible in most other places as well where PC > and s390 differ due to the names of the default devices available. thanks for the reminder :-) Yes, Kevin mentioned that we can use "id=testdisk" because it's the same on all platforms. Please refer this link: http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg03715.html For test 130, I used "qemu -drive id=testdisk" for both pc and s390x. For test 051, I didn't find a way to do the same thing for qemu-io.