From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56026)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2ClC-0002Ob-0B
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 01:43:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2Cl7-0002Nj-0x
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 01:43:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2Cl6-0002NQ-Rp
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 01:43:52 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 489228E22D
	for <qemu-devel@nongnu.org>; Fri, 27 Nov 2015 06:43:52 +0000 (UTC)
References: <1448592497-2462-1-git-send-email-peterx@redhat.com>
	<1448592497-2462-5-git-send-email-peterx@redhat.com>
	<20151127051922.GA10018@ad.usersys.redhat.com>
From: Peter Xu <peterx@redhat.com>
Message-ID: <5657FB9F.1020607@redhat.com>
Date: Fri, 27 Nov 2015 14:43:43 +0800
MIME-Version: 1.0
In-Reply-To: <20151127051922.GA10018@ad.usersys.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event
 DUMP_COMPLETED
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org



On 11/27/2015 01:19 PM, Fam Zheng wrote:
> On Fri, 11/27 10:48, Peter Xu wrote:
>> @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp)
>>  static void *dump_thread(void *data)
>>  {
>>      GlobalDumpState *global = (GlobalDumpState *)data;
>> -    dump_process(global->gds_cur, NULL);
>> +    Error *local_err = NULL;
>> +    const char *msg = "Dump completed successfully";
>> +
>> +    dump_process(global->gds_cur, &local_err);
>>      dump_state_release(global);
>> +
>> +    /* if detach is used, notify user that dump has finished */
>> +    if (local_err) {
>> +        msg = error_get_pretty(local_err);
> 
> error_free?

Yes, thanks!

Peter

> 
> 
>> +    }
>> +    qapi_event_send_dump_completed(msg, &error_abort);
>>      return NULL;
>>  }
>>