From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2CsO-0008Rz-Sy for qemu-devel@nongnu.org; Fri, 27 Nov 2015 01:51:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2CsK-0006em-Qz for qemu-devel@nongnu.org; Fri, 27 Nov 2015 01:51:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2CsK-0006ec-Lk for qemu-devel@nongnu.org; Fri, 27 Nov 2015 01:51:20 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 456E1C0D2227 for ; Fri, 27 Nov 2015 06:51:20 +0000 (UTC) References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-2-git-send-email-peterx@redhat.com> <20151127042824.GA14568@ad.usersys.redhat.com> From: Peter Xu Message-ID: <5657FD5F.1070307@redhat.com> Date: Fri, 27 Nov 2015 14:51:11 +0800 MIME-Version: 1.0 In-Reply-To: <20151127042824.GA14568@ad.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org On 11/27/2015 12:28 PM, Fam Zheng wrote: > I think when write_dump_header() returns a failure, it does call > dump_cleanup(), in create_header{32,64}. > > But the changes of code in this patch look sane to me, and the new error > handling is definitely looking better. Yes, you are right. I will modify the commit message to correct mentioning about memory leak, and keep the codes itself. Thanks. Peter > > Fam