From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2G45-0000O6-V5 for qemu-devel@nongnu.org; Fri, 27 Nov 2015 05:15:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2G41-0000yw-Ux for qemu-devel@nongnu.org; Fri, 27 Nov 2015 05:15:41 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:34815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2G41-0000yL-JH for qemu-devel@nongnu.org; Fri, 27 Nov 2015 05:15:37 -0500 Received: by wmvv187 with SMTP id v187so63958514wmv.1 for ; Fri, 27 Nov 2015 02:15:37 -0800 (PST) Sender: Paolo Bonzini References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-5-git-send-email-peterx@redhat.com> From: Paolo Bonzini Message-ID: <56582D47.6040905@redhat.com> Date: Fri, 27 Nov 2015 11:15:35 +0100 MIME-Version: 1.0 In-Reply-To: <1448592497-2462-5-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org On 27/11/2015 03:48, Peter Xu wrote: > +## > +# @DUMP_COMPLETED > +# > +# Emitted when background dump has completed > +# > +# Since: 2.6 > +## > +{ 'event': 'DUMP_COMPLETED' , > + 'data': { 'msg': 'str' } } This makes it hard to understand whether there was an error or not. I suggest using '*error': 'str' instead, and omitting the error if the dump is successful. Paolo