From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2G6I-0002PX-6A for qemu-devel@nongnu.org; Fri, 27 Nov 2015 05:17:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2G6E-0002H2-Eh for qemu-devel@nongnu.org; Fri, 27 Nov 2015 05:17:58 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2G6E-0002Gd-7k for qemu-devel@nongnu.org; Fri, 27 Nov 2015 05:17:54 -0500 Received: by wmww144 with SMTP id w144so52237320wmw.0 for ; Fri, 27 Nov 2015 02:17:53 -0800 (PST) Sender: Paolo Bonzini References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-6-git-send-email-peterx@redhat.com> <20151127052523.GC10018@ad.usersys.redhat.com> <56580031.5070405@redhat.com> From: Paolo Bonzini Message-ID: <56582DD0.50109@redhat.com> Date: Fri, 27 Nov 2015 11:17:52 +0100 MIME-Version: 1.0 In-Reply-To: <56580031.5070405@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , Fam Zheng Cc: qemu-devel@nongnu.org On 27/11/2015 08:03, Peter Xu wrote: > > > +{ 'struct': 'DumpStatus', > > > + 'data': { 'status': 'str', 'percentage': 'str' } } > > > > I suggest using enum for "status" and int for "percentage" (or two ints for > > "total" and "current"). > > Yes, I picked string just for flexibility. Regarding to this > interface issue, I'd like to wait for others' comments too before > modification. I like Fam's idea of using an enum and two ints. Also, the command should be named query-dump and the corresponding HMP command should be "info dump" (by defining "dump" in hmp-commands-info.h". Paolo