From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Hai-0007co-7d for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:53:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2Had-0002OV-8p for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:53:28 -0500 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:35811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Had-0002OP-2E for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:53:23 -0500 Received: by wmuu63 with SMTP id u63so52749196wmu.0 for ; Fri, 27 Nov 2015 03:53:22 -0800 (PST) Sender: Paolo Bonzini References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-7-git-send-email-peterx@redhat.com> <56582EF8.4030903@redhat.com> <20151127114248.GE10191@pxdev.xzpeter.org> From: Paolo Bonzini Message-ID: <56584431.605@redhat.com> Date: Fri, 27 Nov 2015 12:53:21 +0100 MIME-Version: 1.0 In-Reply-To: <20151127114248.GE10191@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org On 27/11/2015 12:42, Peter Xu wrote: > > As mentioned early, you can use an enum. QEMU usually prints enums in > > lowercase and separates words with "-". Similar to MigrationStatus you > > can use none, active, completed, failed. In fact you might even reuse > > MigrationStatus directly, it's simpler. > > I think it might be a little big confusing if I use MigrationStatus > directly. I can define a enum. Sure, that's fine. Though there is more than a little similarity between migration and dump... (essentially, migration is a dump with a custom format and with additional support for storing device state). Paolo