From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a2Htk-0001w2-CT
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 07:13:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a2Htg-0007TZ-BT
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 07:13:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43613)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a2Htg-0007TV-5l
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 07:13:04 -0500
References: <1448555397-29150-1-git-send-email-asmetanin@virtuozzo.com>
	<1448555397-29150-6-git-send-email-asmetanin@virtuozzo.com>
	<56583BB4.8080600@redhat.com> <56583ED3.3080209@virtuozzo.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <565848CB.9060509@redhat.com>
Date: Fri, 27 Nov 2015 13:12:59 +0100
MIME-Version: 1.0
In-Reply-To: <56583ED3.3080209@virtuozzo.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 5/5] x86: Hyper-V SynIC timers test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: asmetanin@virtuozzo.com, kvm@vger.kernel.org
Cc: "Denis V. Lunev" <den@openvz.org>, Marcelo Tosatti <mtosatti@redhat.com>, Roman Kagan <rkagan@virtuozzo.com>, qemu-devel@nongnu.org



On 27/11/2015 12:30, Andrey Smetanin wrote:
>>>
>>> +
>>> +static void stimer_test_cleanup(void *ctx)
>>> +{
>>> +    irq_enable();
>>
>> Why enable again?
> I'll remove it.

I guess you can remove the one in stimer_test_prepare too.  If the
interrupts are disabled you don't get the IPI either, do you?

Paolo