From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool
Date: Fri, 27 Nov 2015 14:08:47 +0100 [thread overview]
Message-ID: <565855DF.5060100@redhat.com> (raw)
In-Reply-To: <20151127134246.3a33702d@bahia.local>
On 27/11/2015 13:42, Greg Kurz wrote:
> On Fri, 27 Nov 2015 12:43:06 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>> The QEMU thread pool already has a mechanism to invoke callbacks in the main
>> thread. It does not need an EventNotifier and it is more efficient too.
>> Use it instead of GAsyncQueue + GThreadPool + glue.
>>
>> As a side effect, it silences Coverity's complaint about an unchecked
>> return value for event_notifier_init.
>
> And it makes the code a lot nicer too !
Thanks. :)
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>
> I have just one minor remark in hw/9pfs/virtio-9p-coth.h but anyway:
>
> Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> Tested-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Would you like to send a pull request for these patches yourself, and
possibly add yourself to MAINTAINERS? I can help you setting up git
(next week).
Paolo
next prev parent reply other threads:[~2015-11-27 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 11:43 [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool Paolo Bonzini
2015-11-27 12:42 ` Greg Kurz
2015-11-27 13:08 ` Paolo Bonzini [this message]
2015-11-27 14:06 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565855DF.5060100@redhat.com \
--to=pbonzini@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).