From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Ilk-0003CA-J5 for qemu-devel@nongnu.org; Fri, 27 Nov 2015 08:08:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2Ilf-0006Kn-JN for qemu-devel@nongnu.org; Fri, 27 Nov 2015 08:08:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Ilf-0006Kd-E2 for qemu-devel@nongnu.org; Fri, 27 Nov 2015 08:08:51 -0500 References: <1448624586-28299-2-git-send-email-pbonzini@redhat.com> <20151127134246.3a33702d@bahia.local> From: Paolo Bonzini Message-ID: <565855DF.5060100@redhat.com> Date: Fri, 27 Nov 2015 14:08:47 +0100 MIME-Version: 1.0 In-Reply-To: <20151127134246.3a33702d@bahia.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com On 27/11/2015 13:42, Greg Kurz wrote: > On Fri, 27 Nov 2015 12:43:06 +0100 > Paolo Bonzini wrote: > >> The QEMU thread pool already has a mechanism to invoke callbacks in the main >> thread. It does not need an EventNotifier and it is more efficient too. >> Use it instead of GAsyncQueue + GThreadPool + glue. >> >> As a side effect, it silences Coverity's complaint about an unchecked >> return value for event_notifier_init. > > And it makes the code a lot nicer too ! Thanks. :) >> Signed-off-by: Paolo Bonzini >> --- > > I have just one minor remark in hw/9pfs/virtio-9p-coth.h but anyway: > > Reviewed-by: Greg Kurz > Tested-by: Greg Kurz Would you like to send a pull request for these patches yourself, and possibly add yourself to MAINTAINERS? I can help you setting up git (next week). Paolo