From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2OOA-0006P6-Nb for qemu-devel@nongnu.org; Fri, 27 Nov 2015 14:09:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2OO9-0003Tc-La for qemu-devel@nongnu.org; Fri, 27 Nov 2015 14:08:58 -0500 References: <1448294400-476-1-git-send-email-kwolf@redhat.com> <1448294400-476-15-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <5658AA38.2000200@redhat.com> Date: Fri, 27 Nov 2015 20:08:40 +0100 MIME-Version: 1.0 In-Reply-To: <1448294400-476-15-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xvQAdWskahl8mBfvlF2CJCOFvgrfKBW56" Subject: Re: [Qemu-devel] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xvQAdWskahl8mBfvlF2CJCOFvgrfKBW56 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 23.11.2015 16:59, Kevin Wolf wrote: > Creating an empty drive while specifying 'format' doesn't make sense. > The specified format driver would simply be ignored. >=20 > Make a set 'format' option an indication that a non-empty drive should > be created. This makes 'format' consistent with 'driver' and allows > using it with a block driver that doesn't need any other options (like > null-co/null-aio). >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 5 +---- > tests/qemu-iotests/iotests.py | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) Besides the failing make check, the patch looks good. Max --xvQAdWskahl8mBfvlF2CJCOFvgrfKBW56 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWWKo4AAoJEDuxQgLoOKytx0UIAKyh3AEpx3YTXhjJiAx5uxb1 mW68r1zLeeOP7z+oMEuMF2nLORUAGLHXIh5fVprN9WZDk2uI4BmXTbkr8wWLs9my D5/ST79YDpIpUfZN2Vh9VfDd4EWeARmUdNUnNwYTAEkHuKfm4CeRNaEdnGItcF2d qgygmDHG45RlbC3II/h0cgp2dlaDvUD6xmzq+Aix+DBGTh5zJThYFp6xdKsEHObJ mLd6uTVZW86N8JFeGJaAfS0RNLZZs0cNbnnjSqoWSWMYqzi3CRVzmHisjZnVWvx9 eaR+uXSW1u3l/4x4XswNrX2/Vvnoue9a+q76LM1n/s5LJa4DmHDvhURiB7O79cM= =c1rQ -----END PGP SIGNATURE----- --xvQAdWskahl8mBfvlF2CJCOFvgrfKBW56--