From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org
Cc: Diana Craciun <diana.craciun@freescale.com>,
Shlomo Pongratz <shlomo.pongratz@huawei.com>,
Shlomo Pongratz <shlomopongratz@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [RFC PATCH v3 1/5] hw/intc: Implement ITS base class
Date: Sun, 29 Nov 2015 16:10:23 +0800 [thread overview]
Message-ID: <565AB2EF.5000007@huawei.com> (raw)
In-Reply-To: <48b59a60537a0dc5aac45b9015330eb641949ea5.1448359515.git.p.fedin@samsung.com>
On 2015/11/24 18:13, Pavel Fedin wrote:
> +static const VMStateDescription vmstate_its = {
> + .name = "arm_gicv3_its",
> + .pre_save = gicv3_its_pre_save,
> + .post_load = gicv3_its_post_load,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT32(ctlr, GICv3ITSState),
> + VMSTATE_UINT64(cbaser, GICv3ITSState),
> + VMSTATE_UINT64(cwriter, GICv3ITSState),
> + VMSTATE_UINT64(creadr, GICv3ITSState),
> + VMSTATE_UINT64_ARRAY(baser, GICv3ITSState, 8),
> + VMSTATE_END_OF_LIST()
> + }
lack a comma here.
> + .unmigratable = true,
> +};
hw/intc/arm_gicv3_its_common.c:57:5: error: request for member
‘unmigratable’ in something not a structure or union
.unmigratable = true,
^
--
Shannon
next prev parent reply other threads:[~2015-11-29 8:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 10:13 [Qemu-devel] [RFC PATCH v3 0/5] vITS support Pavel Fedin
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 1/5] hw/intc: Implement ITS base class Pavel Fedin
2015-11-27 15:35 ` Peter Maydell
2015-11-30 7:09 ` Pavel Fedin
2015-11-29 8:10 ` Shannon Zhao [this message]
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 2/5] kernel: Add vGICv3 ITS definitions Pavel Fedin
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 3/5] kvm_arm: Pass requester ID to MSI routing functions Pavel Fedin
2015-11-27 15:45 ` Peter Maydell
2015-11-30 6:41 ` Pavel Fedin
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 4/5] kvm_arm: Implement support for ITS emulation by KVM Pavel Fedin
2015-11-27 15:47 ` Peter Maydell
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 5/5] arm/virt: Add ITS to the virt board Pavel Fedin
2015-11-27 16:18 ` Peter Maydell
2015-11-28 3:55 ` Shannon Zhao
2016-06-28 6:41 ` [Qemu-devel] [RFC PATCH v3 0/5] vITS support Auger Eric
2016-06-28 8:25 ` Christoffer Dall
2016-06-29 6:45 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565AB2EF.5000007@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=diana.craciun@freescale.com \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).