From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3H9Q-0004OQ-Rk for qemu-devel@nongnu.org; Mon, 30 Nov 2015 00:37:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3H9N-0005bT-LG for qemu-devel@nongnu.org; Mon, 30 Nov 2015 00:37:24 -0500 Received: from [59.151.112.132] (port=51179 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3H9N-0005Vo-85 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 00:37:21 -0500 References: <1448627251-11186-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <1448627251-11186-2-git-send-email-zhangchen.fnst@cn.fujitsu.com> <565BB981.7040405@cn.fujitsu.com> From: Zhang Chen Message-ID: <565BE0EE.3050900@cn.fujitsu.com> Date: Mon, 30 Nov 2015 13:38:54 +0800 MIME-Version: 1.0 In-Reply-To: <565BB981.7040405@cn.fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 1/9] Init colo-proxy object based on netfilter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu devel , Jason Wang , Stefan Hajnoczi Cc: zhanghailiang , Li Zhijian , Gui jianfeng , "eddie.dong" , "Dr. David Alan Gilbert" , Huang peng , Gong lei , jan.kiszka@siemens.com, hongyang.yang@easystack.cn On 11/30/2015 10:50 AM, Wen Congyang wrote: > On 11/27/2015 08:27 PM, Zhang Chen wrote: >> From: zhangchen >> >> add colo-proxy in vl.c and qemu-options.hx >> >> Signed-off-by: zhangchen >> --- >> qemu-options.hx | 4 ++++ >> vl.c | 3 ++- >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 949db7f..5e6f1e3 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -3666,6 +3666,10 @@ queue @var{all|rx|tx} is an option that can be applied to any netfilter. >> @option{tx}: the filter is attached to the transmit queue of the netdev, >> where it will receive packets sent by the netdev. >> >> +@item -object colo-proxy,id=@var{id},netdev=@var{netdevid},port=@var{t},addr=@var{ip:port},mode=@var{primary|secondary}[,queue=@var{all|rx|tx}] > 1. queue *MUST* be all for the filter colo-proxy. > 2. The option port should be removed > 3. The option addr is socket address. The format can be host:port, or fd. will fix in next version thanks for review zhangchen >> + >> +colo-proxy > Add more description here. > > Thanks > Wen Congyang > will fix in next version >> + >> @item -object filter-dump,id=@var{id},netdev=@var{dev},file=@var{filename}][,maxlen=@var{len}] >> >> Dump the network traffic on netdev @var{dev} to the file specified by >> diff --git a/vl.c b/vl.c >> index f5f7c3f..9037743 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2774,7 +2774,8 @@ static bool object_create_initial(const char *type) >> * they depend on netdevs already existing >> */ >> if (g_str_equal(type, "filter-buffer") || >> - g_str_equal(type, "filter-dump")) { >> + g_str_equal(type, "filter-dump") || >> + g_str_equal(type, "colo-proxy")) { >> return false; >> } >> >> > . >