From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3KVQ-0002B4-6j for qemu-devel@nongnu.org; Mon, 30 Nov 2015 04:12:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3KVM-0003bO-7P for qemu-devel@nongnu.org; Mon, 30 Nov 2015 04:12:20 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:38127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3KVL-0003b0-V3 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 04:12:16 -0500 Received: by wmec201 with SMTP id c201so128647952wme.1 for ; Mon, 30 Nov 2015 01:12:13 -0800 (PST) Sender: Paolo Bonzini References: <20151130034732.GA12255@pxdev.xzpeter.org> From: Paolo Bonzini Message-ID: <565C12EA.5090801@redhat.com> Date: Mon, 30 Nov 2015 10:12:10 +0100 MIME-Version: 1.0 In-Reply-To: <20151130034732.GA12255@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] question: about exec/poison.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org On 30/11/2015 04:47, Peter Xu wrote: > > I met one problem when trying to add a new public function in dump.h > named "dump_state_get_global" and using it in hmp.c. Don't do that. :) hmp.c functions should in general use the QMP commands as the base. In your case, hmp_info_dump should call qmp_query_dump. Paolo