From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a3MXH-0002aF-9I
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:22:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a3MXC-00014W-A2
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:22:23 -0500
Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:37569)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a3MXC-000145-4U
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:22:18 -0500
Received: by wmww144 with SMTP id w144so133011387wmw.0
	for <qemu-devel@nongnu.org>; Mon, 30 Nov 2015 03:22:17 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1448882346-14397-1-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <565C3167.5070009@redhat.com>
Date: Mon, 30 Nov 2015 12:22:15 +0100
MIME-Version: 1.0
In-Reply-To: <1448882346-14397-1-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: silence warning under qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Dmitry Fleytman <dmitry@daynix.com>, Jason Wang <jasowang@redhat.com>



On 30/11/2015 12:19, Michael S. Tsirkin wrote:
> This is not a user error, don't warn.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/net/vmxnet3.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 5e3a233..0e9e6d9 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -25,6 +25,7 @@
>  #include "qemu/bswap.h"
>  #include "hw/pci/msix.h"
>  #include "hw/pci/msi.h"
> +#include "sysemu/qtest.h"
>  
>  #include "vmxnet3.h"
>  #include "vmxnet_debug.h"
> @@ -2015,7 +2016,9 @@ static bool vmxnet3_peer_has_vnet_hdr(VMXNET3State *s)
>          return true;
>      }
>  
> -    VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
> +    if (!qtest_enabled()) {
> +        VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
> +    }
>      return false;
>  }

Let's just delete it, there's no similar warning for virtio.

Paolo