From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3NhE-0006ab-7Z for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:37:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3NgT-0005zs-1y for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:36:44 -0500 Received: from mga14.intel.com ([192.55.52.115]:38274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3NgS-0005za-Qo for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:35:56 -0500 References: <1447671063-92665-1-git-send-email-guangrong.xiao@linux.intel.com> <1447671063-92665-4-git-send-email-guangrong.xiao@linux.intel.com> <20151130103023.GB4862@redhat.com> From: Xiao Guangrong Message-ID: <565C410F.2020305@linux.intel.com> Date: Mon, 30 Nov 2015 20:29:03 +0800 MIME-Version: 1.0 In-Reply-To: <20151130103023.GB4862@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 3/5] nvdimm acpi: build ACPI NFIT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 11/30/2015 06:30 PM, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2015 at 06:51:01PM +0800, Xiao Guangrong wrote: >> NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) >> >> Currently, we only support PMEM mode. Each device has 3 structures: >> - SPA structure, defines the PMEM region info >> >> - MEM DEV structure, it has the @handle which is used to associate specified >> ACPI NVDIMM device we will introduce in later patch. >> Also we can happily ignored the memory device's interleave, the real >> nvdimm hardware access is hidden behind host >> >> - DCR structure, it defines vendor ID used to associate specified vendor >> nvdimm driver. Since we only implement PMEM mode this time, Command >> window and Data window are not needed >> >> The NVDIMM functionality is controlled by the parameter, 'nvdimm-support', >> is introduced for PIIX4_PM and ICH9-LPC, it is true on default and it is >> false on 2.4 and its earlier version to keep compatibility > > Will need to make it false on 2.5 too. > Yes, 2.5 have been released now, it need to be updated. :) > Isn't there a device that needs to be created for this > to work? It would be cleaned to just key off Yes. But no nvdimm device/NFIT exists if no nvdimm device is specified by QEMU command line. > the device presence, then we don't need compat gunk, > and further, people not using it don't get a > bunch of unused AML. I am okay to make it off on default.