From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3NlU-0000LG-1U for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:41:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3Nkh-0008Q2-Ro for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:41:07 -0500 Received: from mga14.intel.com ([192.55.52.115]:12370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Nkh-0008Oh-IP for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:40:19 -0500 References: <1447671063-92665-1-git-send-email-guangrong.xiao@linux.intel.com> <20151130123702-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <565C4216.4090804@linux.intel.com> Date: Mon, 30 Nov 2015 20:33:26 +0800 MIME-Version: 1.0 In-Reply-To: <20151130123702-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 11/30/2015 06:38 PM, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2015 at 06:50:58PM +0800, Xiao Guangrong wrote: >> This patchset can be found at: >> https://github.com/xiaogr/qemu.git nvdimm-v8 >> >> It is based on pci branch on Michael's tree and the top commit is: >> commit e3a4e177d9 (migration/ram: fix build on 32 bit hosts). >> >> Changelog in v8: >> We split the long patch series into the small parts, as you see now, this >> is the first part which enables NVDIMM without label data support. > > Finally found some time to review this. Very nice, this is making good > progress, and I think to split it like this is a great idea. I sent > some comments, most of them minor. > Thanks for your time and really happy to see you like it. :)