From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Nz3-0004vJ-PU for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:55:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3Nz1-000688-3L for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:55:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Nz0-00067b-V2 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 07:55:07 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 78CE0C0D223A for ; Mon, 30 Nov 2015 12:55:06 +0000 (UTC) References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-6-git-send-email-peterx@redhat.com> From: Paolo Bonzini Message-ID: <565C4725.4000604@redhat.com> Date: Mon, 30 Nov 2015 13:55:01 +0100 MIME-Version: 1.0 In-Reply-To: <1448883140-20249-6-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: drjones@redhat.com, famz@redhat.com, lersek@redhat.com, armbru@redhat.com, lcapitulino@redhat.com On 30/11/2015 12:32, Peter Xu wrote: > if (*errp) { > s->status = DUMP_STATUS_FAILED; Why not move this "if" to dump_process as well? Paolo