From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3SuZ-00070k-MJ for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:10:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3SuW-0002qi-Di for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:10:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3SuW-0002qV-53 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:10:48 -0500 References: <1448679706-23771-1-git-send-email-chen_han_xiao@126.com> <1448679706-23771-2-git-send-email-chen_han_xiao@126.com> From: Eric Blake Message-ID: <565C911F.8020605@redhat.com> Date: Mon, 30 Nov 2015 11:10:39 -0700 MIME-Version: 1.0 In-Reply-To: <1448679706-23771-2-git-send-email-chen_han_xiao@126.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AguDJ6BQDPO1DP2w7cHMXksCWsHI7Pu5i" Subject: Re: [Qemu-devel] [PATCH v2 1/2] qmp: add support for system_suspend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Hanxiao , Luiz Capitulino , Markus Armbruster Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AguDJ6BQDPO1DP2w7cHMXksCWsHI7Pu5i Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/27/2015 08:01 PM, Chen Hanxiao wrote: > From: Chen Hanxiao >=20 > This patch add support for system_suspend qmp command. >=20 > Signed-off-by: Chen Hanxiao > --- > qapi-schema.json | 9 +++++++++ > qmp-commands.hx | 21 +++++++++++++++++++++ > qmp.c | 5 +++++ > 3 files changed, 35 insertions(+) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 8b1a423..78bbb29 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3971,3 +3971,12 @@ > ## > { 'enum': 'ReplayMode', > 'data': [ 'none', 'record', 'play' ] } > + > +## > +# @system_suspend: > +# > +# Performs suspend operation of a guest. > +# > +# Since: 2.5 > +## > +{ 'command': 'system_suspend' } You've missed 2.5; this should be since 2.6. Also, new QMP commands should be named with '-' rather than '_'; so this should be 'system-suspend'. (Yes, I know 'system_wakeup' already exists with the older spelling). How does this command differ from the existing ability to use qemu-guest-agent to request the guest put itself into suspend state? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AguDJ6BQDPO1DP2w7cHMXksCWsHI7Pu5i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXJEfAAoJEKeha0olJ0Nq1fcIAIJ7dIX4ScAXBo2mzIG5pbae EXHZ+490FiDQ+bTTG5D80XiMLwgmFT9hvR/MY7j3+TMYXlzmOY6jCsGzFOB2I1x/ 85+PbjaXPgsVzstglsT2Og4yjnjX9Fn+TJ3Z++o8j6o/EQCAhNpVrz57wXX8vMEj TKzgPHGkh1Ls2WS9/xKlmZpbCl7LW+czED5/pSX95m3N1MV4dvuqHhhkOt1khNp1 XEOB2P58eCH8kZFx21l4D2PlhGEROG1MJ/Pk46JfKF9Oo98956kfZrq/uHALH/OF YVkCz+yqYBhcUvXcJ2PfaBnP1iwwjkc9wVkVetLF3XZuGQhXa3ej/Q6A4sHQVLE= =uU5Y -----END PGP SIGNATURE----- --AguDJ6BQDPO1DP2w7cHMXksCWsHI7Pu5i--