From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3T2X-0005PM-QF for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:19:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3T2T-0005Op-3w for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:19:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3T2S-0005Ok-SC for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:19:01 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id EBF98C0D2233 for ; Mon, 30 Nov 2015 18:18:59 +0000 (UTC) References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-5-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <565C9308.3090901@redhat.com> Date: Mon, 30 Nov 2015 11:18:48 -0700 MIME-Version: 1.0 In-Reply-To: <1448592497-2462-5-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ip9LAq3bkhDJ7COhxOCiki96CI5WV7dTj" Subject: Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ip9LAq3bkhDJ7COhxOCiki96CI5WV7dTj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/26/2015 07:48 PM, Peter Xu wrote: > To get aligned with QMP interface, one new QMP event DUMP_COMPLETED > is added. It is used when user specified "detach" in dump, and > triggered when the dump finishes. Error message will be appended to > this event if the dump has failed. Why not emit the new event unconditionally, instead of only when detach was specified? >=20 > Signed-off-by: Peter Xu > --- > docs/qmp-events.txt | 12 ++++++++++++ > dump.c | 12 +++++++++++- > qapi/event.json | 10 ++++++++++ > 3 files changed, 33 insertions(+), 1 deletion(-) >=20 > diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt > index d2f1ce4..fe494f9 100644 > --- a/docs/qmp-events.txt > +++ b/docs/qmp-events.txt > @@ -674,3 +674,15 @@ Note: If action is "reset", "shutdown", or "pause"= the WATCHDOG event is > followed respectively by the RESET, SHUTDOWN, or STOP events. > =20 > Note: this event is rate-limited. > + > +DUMP_COMPLETED > +-------------- > + > +Emitted when the guest has finished one memory dump. > + > +Data: None. Wrong - you have 'msg' as data. Except that Paolo is right, 'msg' should be optional, and only present on error. You should also document that the contents of 'msg' are for human consumption and should not be machine-parsed (basically, only the presence of absence of 'msg' is useful for machines). > + > +Example: > + > +{ "event": "DUMP_COMPLETED", > + "data": { "msg": "Dump completed successfully" } } > diff --git a/dump.c b/dump.c > +++ b/qapi/event.json > @@ -356,3 +356,13 @@ > ## > { 'event': 'MEM_UNPLUG_ERROR', > 'data': { 'device': 'str', 'msg': 'str' } } > + > +## > +# @DUMP_COMPLETED > +# > +# Emitted when background dump has completed > +# Missing documentation of 'msg', which should be optional. > +# Since: 2.6 > +## > +{ 'event': 'DUMP_COMPLETED' , > + 'data': { 'msg': 'str' } } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ip9LAq3bkhDJ7COhxOCiki96CI5WV7dTj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXJMIAAoJEKeha0olJ0NqzjoH/jj5eZ8Cv8ai7rgQQ3HuUVUE XE8BbJxrHmoCLuaPYta+3Yj/L8utKdOu3xOVF3xTaourZTxcA5fgyEFppWXUVlsW lf63fcrG37zeff6/igIr8ij/81hKSRJ+R59sYwg8Mu37/T3zoBo0FuHwp0+dhgoj SjId+eD94zJImmlyup+0w8Xtj6K5STXBTT6yHkuPxYwB2AzD1zehm2mMR5AxnOHI 9vVnoC9Fc6og3acuavDTpJOqaim7SU8jRQkI52CDB4LXIa4Vs5N8VnWL2fNTG3MO SS/6j0La5Z9nxfy4Pk+d0FWOVW8+7nT4AdguOYMlnD4wyJaomIz/sGVrE7cH+4g= =7r7M -----END PGP SIGNATURE----- --ip9LAq3bkhDJ7COhxOCiki96CI5WV7dTj--