From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3T51-00073Z-OH for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:21:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3T4s-00061t-3W for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:21:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3T4r-00061o-Rq for qemu-devel@nongnu.org; Mon, 30 Nov 2015 13:21:30 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 644A88EA3B for ; Mon, 30 Nov 2015 18:21:29 +0000 (UTC) References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-3-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <565C93A3.1050302@redhat.com> Date: Mon, 30 Nov 2015 11:21:23 -0700 MIME-Version: 1.0 In-Reply-To: <1448592497-2462-3-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L9PSAPRQqWf45E8kh016BfELoPF2sxOHO" Subject: Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L9PSAPRQqWf45E8kh016BfELoPF2sxOHO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/26/2015 07:48 PM, Peter Xu wrote: > This patch only adds the interfaces, but not implements them. s/not implements/does not implement/ > "detach" parameter is made optional, to make sure that all the old > dump-guest-memory requests will still be able to work. >=20 > Signed-off-by: Peter Xu > --- In addition to Fam's comments, > +++ b/qapi-schema.json > @@ -2115,6 +2115,9 @@ > # 2. fd: the protocol starts with "fd:", and the following = string > # is the fd's name. > # > +# @detach: #optional if true, QMP will return immediately rather than > +# waiting dump to be finished (since 2.6). s/waiting/waiting for the/ s/be finished/finish/ > +++ b/qmp-commands.hx > @@ -840,8 +840,8 @@ EQMP > =20 > { > .name =3D "dump-guest-memory", > - .args_type =3D "paging:b,protocol:s,begin:i?,end:i?,format:s?= ", > - .params =3D "-p protocol [begin] [length] [format]", > + .args_type =3D "paging:b,protocol:s,detach:b?,begin:i?,end:i?= ,format:s?", > + .params =3D "-p protocol [-d] [begin] [length] [format]", > .help =3D "dump guest memory to file", > .mhandler.cmd_new =3D qmp_marshal_dump_guest_memory, > }, > @@ -857,6 +857,8 @@ Arguments: > - "paging": do paging to get guest's memory mapping (json-bool) > - "protocol": destination file(started with "file:") or destination fi= le > descriptor (started with "fd:") (json-string) > +- "detach": if specificed, command will return immediately, without wa= iting s/specificed/specified/ > + for dump to be finished (json-bool) s/dump to be finished/the dump to finish/ > - "begin": the starting physical address. It's optional, and should be= specified > with length together (json-int) > - "length": the memory size, in bytes. It's optional, and should be sp= ecified >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --L9PSAPRQqWf45E8kh016BfELoPF2sxOHO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXJOjAAoJEKeha0olJ0NqqaUIAIUUhQw39byv2HXTMGL0ULHP 6T8IDcG8Ek1NBdysfbzNzzGmSjlxXK7jetvzrh8gQrU++FoOCxDlVx6OWcr2ykSa h+HeBXF2Qpyn3qeEaPJs9+wg5FlAhdWKoK/dMiX/kELv8D7mmztGgHW9elc9d9k1 FD9Pt4+b/gdjNWKXfxAdLLkrFc8huBexg8jZ44rUSAK8WlM7U+dAffOkXQtgT64B YS9ocNH+ZJML+BCVzLFi8KKzUtRVORQbX/wgxPyyJOTZ9tCXR1m8koCxCJWBNgH0 kJmZ0Xxj4Ye7upye74pIw4mA8ZExErIZHnBzP4r6zrgD5ZGXF2SEbGXVgjYxmr8= =CceO -----END PGP SIGNATURE----- --L9PSAPRQqWf45E8kh016BfELoPF2sxOHO--