From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3WcY-0003la-Gc for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:08:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3WcU-0004I8-GQ for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:08:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3WcU-0004I4-Am for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:08:26 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E9F12C06C9C9 for ; Mon, 30 Nov 2015 22:08:25 +0000 (UTC) References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-4-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <565CC8D8.4020607@redhat.com> Date: Mon, 30 Nov 2015 15:08:24 -0700 MIME-Version: 1.0 In-Reply-To: <1448883140-20249-4-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hHrlcjCkCt8oWWLF7rBHUJ3UDUDrkB5ds" Subject: Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: drjones@redhat.com, famz@redhat.com, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hHrlcjCkCt8oWWLF7rBHUJ3UDUDrkB5ds Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/30/2015 04:32 AM, Peter Xu wrote: > Instead of malloc/free each time for DumpState, make it > static. Added DumpStatus to show status for dump. >=20 > This is to be used for detach dump. s/detach/detached/ >=20 > Signed-off-by: Peter Xu > --- > dump.c | 30 +++++++++++++++++++++++++++--- > include/sysemu/dump.h | 2 ++ > qapi-schema.json | 18 ++++++++++++++++++ > 3 files changed, 47 insertions(+), 3 deletions(-) >=20 In addition to Paolo's review, > +++ b/qapi-schema.json > @@ -2139,6 +2139,24 @@ > '*format': 'DumpGuestMemoryFormat'} } > =20 > ## > +# @DumpStatus > +# > +# Define the status for dump guest memory. Reads awkwardly. Maybe: Describe the status of a long-running background guest memory dump. > +# > +# @none: not started any dump-guest-memory yet. @none: no dump-guest-memory has started yet > +# > +# @active: there is one dump running in background. > +# > +# @completed: the last dump has finished sucessfully s/sucessfully/successfully/ Inconsistent on whether your lines end in '.' > +# > +# @failed: the last dump has failed. > +# > +# Since 2.6 > +## > +{ 'enum': 'DumpStatus', > + 'data': [ 'none', 'active', 'completed', 'failed' ] } > + > +## > # @DumpGuestMemoryCapability: > # > # A list of the available formats for dump-guest-memory >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hHrlcjCkCt8oWWLF7rBHUJ3UDUDrkB5ds Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXMjYAAoJEKeha0olJ0NqmoAH/jXIrt2SNrI9ykjz5k/fZrIH mdCPFb6IxbkVWy4ic6lqsnf4480jhauYKZAdLh+zxb7pikGQhUeGw1wxeA/NtAa9 7vRM7MflUk1kRZPL41OtwGbPnFvf6IuFKzjmIGrH3PbL0FGWVkEJy8KS19gEIg+F n5IuMFoUoD+2t5Y5k23SaF0rtGwKmnmeg42U1mNtBleN6+1zQFMga1OBmlGw0BJs q1sJ0ZW8yvcYL28WFgUPx9Q19H68z6dSqDXKThwJEF1IQxk+vxYBAbhDXMB0oT9i OZiWYAmjrUJ444KChju2kP5DJ20+//EM8EwXcEmluqNbbx/q2adAI6074MOzbu4= =pFhi -----END PGP SIGNATURE----- --hHrlcjCkCt8oWWLF7rBHUJ3UDUDrkB5ds--