From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3WgX-00072z-AB for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:12:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3WgT-0005S3-8N for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:12:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3WgT-0005Ry-0a for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:12:33 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 87291C0B7ADA for ; Mon, 30 Nov 2015 22:12:32 +0000 (UTC) References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-9-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <565CC9CF.7070401@redhat.com> Date: Mon, 30 Nov 2015 15:12:31 -0700 MIME-Version: 1.0 In-Reply-To: <1448883140-20249-9-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0voanl0fUekbTmj8WXm4ERxpNKro17wfJ" Subject: Re: [Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: drjones@redhat.com, famz@redhat.com, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0voanl0fUekbTmj8WXm4ERxpNKro17wfJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/30/2015 04:32 AM, Peter Xu wrote: > One new QMP event DUMP_COMPLETED is added. It is used when user > specified "detach" in dump, and triggered when the dump finishes > (either succeeded or failed). If failed, one "err" data will be > passed with specific error message. >=20 > Signed-off-by: Peter Xu > --- > docs/qmp-events.txt | 14 ++++++++++++++ > dump.c | 6 +++++- > qapi/event.json | 10 ++++++++++ > 3 files changed, 29 insertions(+), 1 deletion(-) >=20 > diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt > index d2f1ce4..7b9f835 100644 > --- a/docs/qmp-events.txt > +++ b/docs/qmp-events.txt > @@ -674,3 +674,17 @@ Note: If action is "reset", "shutdown", or "pause"= the WATCHDOG event is > followed respectively by the RESET, SHUTDOWN, or STOP events. > =20 > Note: this event is rate-limited. > + > +DUMP_COMPLETED > +-------------- > + > +Emitted when the guest has finished one memory dump. > + > +Data: > + > +- "error": Error message when dump failed (json-string, optional) > + > +Example: > + > +{ "event": "DUMP_COMPLETED", > + "data": {} } Please keep this file sorted. The insertion should be between DEVICE_TRAY_MOVED and GUEST_PANICKED. > diff --git a/dump.c b/dump.c > index 14fd41f..43f565d 100644 > --- a/dump.c > +++ b/dump.c > @@ -25,6 +25,7 @@ > #include "qapi/error.h" > #include "qapi/qmp/qerror.h" > #include "qmp-commands.h" > +#include "qapi-event.h" > =20 > #include > #ifdef CONFIG_LZO > @@ -1633,8 +1634,11 @@ static void *dump_thread(void *data) > dump_process(s, &err); > =20 > if (err) { > - /* TODO: notify user the error */ > + qapi_event_send_dump_completed(true, error_get_pretty(err), > + &error_abort); > error_free(err); > + } else { > + qapi_event_send_dump_completed(false, NULL, &error_abort); > } Hmmm. I wonder if error_get_pretty() should be improved to return NULL when there is no error. Then we could write: qapi_event_send_dump_completed(!!err, error_get_pretty(err), &error_abort); error_free(err); But that doesn't affect the correctness of your patch. > return NULL; > } > diff --git a/qapi/event.json b/qapi/event.json > index f0cef01..c46214b 100644 > --- a/qapi/event.json > +++ b/qapi/event.json > @@ -356,3 +356,13 @@ > ## > { 'event': 'MEM_UNPLUG_ERROR', > 'data': { 'device': 'str', 'msg': 'str' } } > + > +## > +# @DUMP_COMPLETED > +# > +# Emitted when background dump has completed > +# > +# Since: 2.6 Missing documentation of 'error'. > +## > +{ 'event': 'DUMP_COMPLETED' , > + 'data': { '*error': 'str' } } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0voanl0fUekbTmj8WXm4ERxpNKro17wfJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXMnPAAoJEKeha0olJ0NqjDMH/i3JP/v9SbgWoaFrAkRBfvt2 IjUAB2XQpMpJCPbW77wmql5UAZ4Rhvru0Y4uXoxv2otRFwQ80YRdIHnqL8HFoHKB 6mV9haoiSfR4HYrRSDXz3LJ8rvdLhyIV5I7NeR5+cIn/glNhtjPrk1BXUYrvO5Gd pI6lZwNu34h2wpDWI0MMa4KM7hZhBfVZSr7NOOaVXyayWEY0tjtR+eIQF7wDsd3Y lZ4kAXOBPTMkfI//t1poO4UkLrgn89DoiSRD4JpKZ+ZiZJsY8+u8GQF05XGNNOcQ KfsCnXuHDe9bY3CVZvbATwjwPjQSUFHY7gOpsYvynPGipA0Z+2E5XF29Y1QWN5M= =v71J -----END PGP SIGNATURE----- --0voanl0fUekbTmj8WXm4ERxpNKro17wfJ--