From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3WqJ-00032B-75 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:22:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3WqG-0008KK-0d for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:22:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3WqF-0008KE-Pd for qemu-devel@nongnu.org; Mon, 30 Nov 2015 17:22:39 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 52E4196F6 for ; Mon, 30 Nov 2015 22:22:39 +0000 (UTC) References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-13-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <565CCC2D.9050503@redhat.com> Date: Mon, 30 Nov 2015 15:22:37 -0700 MIME-Version: 1.0 In-Reply-To: <1448883140-20249-13-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xTfSeUxrukJ3OB1BAge99UJMIACeFMqvr" Subject: Re: [Qemu-devel] [PATCH v3 12/12] Dump: enhance the documentations. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: drjones@redhat.com, famz@redhat.com, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xTfSeUxrukJ3OB1BAge99UJMIACeFMqvr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/30/2015 04:32 AM, Peter Xu wrote: > Add more documents to mention about "query-dump" and DUMP_COMPLETED > events. >=20 > Signed-off-by: Peter Xu > --- > qapi-schema.json | 7 +++++-- > qmp-commands.hx | 4 +++- > 2 files changed, 8 insertions(+), 3 deletions(-) Why not squash this in to the patch that introduces the options? No need to have churn within the series by tweaking the documentation more than once. >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 577c381..ce4acb2 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2115,8 +2115,11 @@ > # 2. fd: the protocol starts with "fd:", and the following = string > # is the fd's name. > # > -# @detach: #optional if true, QMP will return immediately rather than > -# waiting dump to be finished (since 2.6). > +# @detach: #optional if true, QMP will return immediately rather > +# than waiting dump to be finished. If this is specified, > +# user could later use "query-dump" to check latest dump > +# status. When dump finishes, one event DUMP_COMPLETED will s/one event DUMP_COMPLETED/a DUMP_COMPLETED event/ > +# be sent to the user to notify the completion (since 2.6). s/to the user to notify the completion// > # > # @begin: #optional if specified, the starting physical address. > # > diff --git a/qmp-commands.hx b/qmp-commands.hx > index ac6d2da..cd097d4 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -858,7 +858,9 @@ Arguments: > - "protocol": destination file(started with "file:") or destination fi= le > descriptor (started with "fd:") (json-string) > - "detach": if specificed, command will return immediately, without wa= iting > - for dump to be finished (json-bool) > + for dump to be finished. After command return, user > + could query for latest dump status using "query-dump". Whe= n dump > + finishes, an event DUMP_COMPLETED will be sent (json-bool)= Awkward. How about: - "detach": if specified, the command will return immediately rather than waiting for the dump completion. The user can track progress with "query-dump", and a DUMP_COMPLETED event will occur at the end. (json-boo= l) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xTfSeUxrukJ3OB1BAge99UJMIACeFMqvr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXMwtAAoJEKeha0olJ0Nq14IIAIniUIsMOWxa3mCsU+ukRP/g BVQpWcwqtmeDwnBgMwsWLHJRS2qO/dUZdnYY3FllaIpKCRrBGxYw0H4F3ZOfkKzr BebUH0W1Kxhlz45IdMIMjhbqk7WGRUcqk+MV0dm1O/Ky90pu7TV+zZ6UTpRsTFWg zS3L6w8m2vlNjvToSiXw8zNR1+sqxX6gyKWLJ//aD2Co87bN1qR/C4NZohlNJJTD K2TjZuwEPnwMRm8gkhM3GFEMf5yC7Dsr8hUg+Kmge9Jb5numnJlsbJYUdhEx6Wn7 Dn3UlgSYfA+TnIF1r6OTM5q02axTZE2N/snMaocqK4w7u6u1p4WLI6a17k1PV1Y= =OeCq -----END PGP SIGNATURE----- --xTfSeUxrukJ3OB1BAge99UJMIACeFMqvr--