From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3kKx-0008KA-Pe for qemu-devel@nongnu.org; Tue, 01 Dec 2015 07:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3kKu-0007g4-EE for qemu-devel@nongnu.org; Tue, 01 Dec 2015 07:47:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3kKu-0007fq-8j for qemu-devel@nongnu.org; Tue, 01 Dec 2015 07:47:12 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id DF6848E22D for ; Tue, 1 Dec 2015 12:47:11 +0000 (UTC) References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-11-git-send-email-peterx@redhat.com> <565C478A.8080106@redhat.com> <20151201035755.GI21032@pxdev.xzpeter.org> <565D6E68.1060303@redhat.com> <20151201123250.GA31109@pxdev.xzpeter.org> <565D9491.5000909@redhat.com> <20151201124545.GB31109@pxdev.xzpeter.org> From: Paolo Bonzini Message-ID: <565D96CC.6020304@redhat.com> Date: Tue, 1 Dec 2015 13:47:08 +0100 MIME-Version: 1.0 In-Reply-To: <20151201124545.GB31109@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, lcapitulino@redhat.com On 01/12/2015 13:45, Peter Xu wrote: >> > It's a matter of taste though. What you wrote above is certainly okay >> > as well. > Thanks for the explanation. Then I will choose smp_*() this time and > post v4 later. In that case, remember to add a comment before each smp_*(), similar to the one in thread-pool.c. Paolo