From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1a3kkM-00066q-UQ
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:13:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1a3kkH-0007aV-7M
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:13:30 -0500
Message-ID: <565D9CD8.1090605@huawei.com>
Date: Tue, 1 Dec 2015 21:12:56 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1447680189-2128-1-git-send-email-shannon.zhao@linaro.org>	<1447680189-2128-4-git-send-email-shannon.zhao@linaro.org>	<20151201124127.1045c90c@nial.brq.redhat.com>	<565D95F8.5040805@huawei.com>
	<20151201140532.340805f8@nial.brq.redhat.com>
In-Reply-To: <20151201140532.340805f8@nial.brq.redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add power
 button device in ACPI DSDT table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: wei@redhat.com, peter.maydell@linaro.org, graeme.gregory@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, qemu-arm@nongnu.org, shannon.zhao@linaro.org

Hi Igor,

On 2015/12/1 21:05, Igor Mammedov wrote:
>>>>> +static void acpi_dsdt_add_power_button(Aml *scope)
>>>>> > >> > +{
>>>>> > >> > +    Aml *dev = aml_device("PWRB");
>>>>> > >> > +    aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
>>>>> > >> > +    aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
>>>>> > >> > +    aml_append(dev, aml_name_decl("_UID", aml_int(0)));
>>>>> > >> > +    Aml *method = aml_method("_STA", 0);
>>>>> > >> > +    aml_append(method, aml_return(aml_int(0x0F)));
>>>>> > >> > +    aml_append(dev, method);
>>> > > since _STA always returns 0xF you can just drop it altogether,
>>> > > as _STA == 0xF is implied if it's not present.
>>> > > 
>> > 
>> > Yes, but I think adding this is harmless and make the return value explicit.
> It's useless and consumes several bytes, it's better to drop it unless you have to have it.
> 
Sure, will drop it. :)

BTW, could you have a look at other ACPI patches in this series? Thanks
in advance!

-- 
Shannon