From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3kkJ-000656-WC for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:13:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3kkG-0007aQ-RK for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:13:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3kkG-0007aL-LE for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:13:24 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 3FC9A71 for ; Tue, 1 Dec 2015 13:13:24 +0000 (UTC) References: <1448975034-1314-1-git-send-email-armbru@redhat.com> From: Paolo Bonzini Message-ID: <565D9CF2.10300@redhat.com> Date: Tue, 1 Dec 2015 14:13:22 +0100 MIME-Version: 1.0 In-Reply-To: <1448975034-1314-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] coverity: Model g_poll() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org On 01/12/2015 14:03, Markus Armbruster wrote: > Coverity now reports two more CHECKED_RETURN: > > * qemu-char.c:1248: Should be fixed by Paolo's "qemu-char: retry > g_poll on EINTR". > > * migration/qemu-file-unix.c:75: if g_poll() fails, we retry sending > before the file descriptor is ready. Errors other than EINTR are > mostly theoretical, though. EINTR is harmless too here, you'll just get another EAGAIN. I'll mark it as Intentional / Fix Required in the coverity dashboard. Paolo > Signed-off-by: Markus Armbruster > ---