From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3l9U-0000Dw-Ps for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:39:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3l9Q-0006p9-OI for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:39:28 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:37802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3l9Q-0006p4-Hz for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:39:24 -0500 Received: by wmww144 with SMTP id w144so13687859wmw.0 for ; Tue, 01 Dec 2015 05:39:23 -0800 (PST) Sender: Paolo Bonzini References: <1448976854-10346-1-git-send-email-armbru@redhat.com> From: Paolo Bonzini Message-ID: <565DA309.3080201@redhat.com> Date: Tue, 1 Dec 2015 14:39:21 +0100 MIME-Version: 1.0 In-Reply-To: <1448976854-10346-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: Clean up use of g_poll() in socket_writev_buffer() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, quintela@redhat.com On 01/12/2015 14:34, Markus Armbruster wrote: > socket_writev_buffer() writes in a loop, using g_poll() to block. If > g_poll() fails, it tries to write more before the file descriptor is > ready. In theory, this could go into a tight loop. In practice, > errors other than EINTR are really unlikely, and when they happen, > we're probably screwed anyway, so we can just as well loop. > > Clean it up a bit: retry poll on EINTR, keep ignoring other errors. > > Signed-off-by: Markus Armbruster > --- > Let me stress once again: this is *not* a bug fix, it's cleanup! If > you don't like it, you can safely ignore it. We'll then mark the spot > as intentional in the Coverity dashboard. > > migration/qemu-file-unix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration/qemu-file-unix.c b/migration/qemu-file-unix.c > index c503b02..6ca53e7 100644 > --- a/migration/qemu-file-unix.c > +++ b/migration/qemu-file-unix.c > @@ -72,7 +72,8 @@ static ssize_t socket_writev_buffer(void *opaque, struct iovec *iov, int iovcnt, > pfd.fd = s->fd; > pfd.events = G_IO_OUT | G_IO_ERR; > pfd.revents = 0; > - g_poll(&pfd, 1 /* 1 fd */, -1 /* no timeout */); > + TFR(err = g_poll(&pfd, 1, -1 /* no timeout */)); > + /* Errors other than EINTR intentionally ignored */ > } > } > > Reviewed-by: Paolo Bonzini