From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3lDS-0001hZ-Lz for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:43:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3lDR-0007nn-Mz for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:43:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3lDR-0007ni-Hc for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:43:33 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 3FA1DC0B7ABF for ; Tue, 1 Dec 2015 13:43:33 +0000 (UTC) References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-11-git-send-email-peterx@redhat.com> <565CCADD.1050904@redhat.com> <20151201044037.GK21032@pxdev.xzpeter.org> From: Eric Blake Message-ID: <565DA3FE.9080005@redhat.com> Date: Tue, 1 Dec 2015 06:43:26 -0700 MIME-Version: 1.0 In-Reply-To: <20151201044037.GK21032@pxdev.xzpeter.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nl7pjXegAtTsa2M558oJS8i2k68IcnFGq" Subject: Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: drjones@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nl7pjXegAtTsa2M558oJS8i2k68IcnFGq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/30/2015 09:40 PM, Peter Xu wrote: >>> +++ b/qmp-commands.hx >>> @@ -881,7 +881,7 @@ EQMP >>> { >>> .name =3D "query-dump-guest-memory-capability", >>> .args_type =3D "", >>> - .mhandler.cmd_new =3D qmp_marshal_query_dump_guest_memory_capabi= lity, >>> + .mhandler.cmd_new =3D qmp_marshal_query_dump_guest_memory_ca= pability, >>> }, >> >> Unrelated hunk. >=20 > Is it ok to have this line here? I just saw it and fixed it. Please > let me know if I should move it out of this patch. It's small enough that you could separate that hunk into its own patch and cc qemu-trivial. As it is, Marc-Andre has queued patches that get rid of qmp-commands.hx; so if Markus and I can get through the backlog of qapi patches, this problem may just disappear on its own. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nl7pjXegAtTsa2M558oJS8i2k68IcnFGq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXaP+AAoJEKeha0olJ0NqpDEH/AnsIqnWPVXrtlu/+8tsuuH/ /ZzSehj7HPDVgXrhOsQVHLROkINRL7IX9OesZLRcicmj8bKbR/XSC168F0qOAqZz NzTz7shqGpgrdZHtPUZ4TiEvuNyP9C8XQImUo34UR/gTyOnIMLoYdzY2yKPgu6NK X87ZndyCiyv3JZ7SqeVv6dF+WfKKzR//5fAq7xVtcsAAXiMmhTD2SvW/+/2vbWDG MsLBmaohnOwlttn2C5pzGrIxomG9LfqxKkz/qM7socBGJuxBomZMWrUhO6I//LB5 kHsrdPOv2m2mgTS3vS3Rl3KXFXTZsu28mPU2w1yg/qqZ6XzJi6b2AzmdVoqLf3w= =YvgX -----END PGP SIGNATURE----- --nl7pjXegAtTsa2M558oJS8i2k68IcnFGq--