From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41715)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a3lvf-0005Z3-Mh
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 09:29:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a3lvb-0004Mi-JQ
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 09:29:15 -0500
Received: from relay.parallels.com ([195.214.232.42]:37412)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a3lvb-0004Ma-BQ
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 09:29:11 -0500
References: <1447687950-29350-1-git-send-email-den@openvz.org>
	<1447687950-29350-3-git-send-email-den@openvz.org>
	<87ziyd0wdm.fsf@blackfin.pond.sub.org> <87mvubmtef.fsf@emacs.mitica>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <565DAEAB.6060104@openvz.org>
Date: Tue, 1 Dec 2015 17:28:59 +0300
MIME-Version: 1.0
In-Reply-To: <87mvubmtef.fsf@emacs.mitica>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com, Markus Armbruster <armbru@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org

On 11/18/2015 02:36 PM, Juan Quintela wrote:
> Markus Armbruster <armbru@redhat.com> wrote:
>> "Denis V. Lunev" <den@openvz.org> writes:
>>
>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>>> CC: Juan Quintela <quintela@redhat.com>
>>> CC: Amit Shah <amit.shah@redhat.com>
>>> CC: Markus Armbruster <armbru@redhat.com>
>>> CC: Eric Blake <eblake@redhat.com>
>>> ---
>>>   migration/savevm.c |  5 +++++
>>>   qapi-schema.json   | 13 +++++++++++++
>>>   qmp-commands.hx    | 25 +++++++++++++++++++++++++
>>>   3 files changed, 43 insertions(+)
>>>
>>> diff --git a/migration/savevm.c b/migration/savevm.c
>>> index f83ffd0..565b10a 100644
>>> --- a/migration/savevm.c
>>> +++ b/migration/savevm.c
>>> @@ -2010,6 +2010,11 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
>>>       }
>>>   }
>>>   
>>> +void qmp_savevm(bool has_name, const char *name, Error **errp)
>>> +{
>>> +    do_savevm(has_name ? name : NULL, errp);
>>> +}
>>> +
>> Please name do_savevm() qmp_savevm() and drop this wrapper.
>>
>> We're working on omitting has_FOO for pointer-valued FOO.
> Agreed.
>

is there a tree with this stuff in or something I could be based on?
This series is simple enough to be written fast and be merged
early when the hard freeze will be done.

Above stuff could have a way harder way due to the amount of
changes to be performed.

Den