From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chen_han_xiao@126.com>) id 1a3m8J-0003ER-Ns
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 09:42:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chen_han_xiao@126.com>) id 1a3m8G-0000Tg-CW
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 09:42:19 -0500
Received: from m50-110.126.com ([123.125.50.110]:55326)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chen_han_xiao@126.com>) id 1a3m8F-0000Qp-6l
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 09:42:16 -0500
Message-ID: <565DB1B7.6010903@126.com>
Date: Tue, 01 Dec 2015 22:41:59 +0800
From: Chen Hanxiao <chen_han_xiao@126.com>
MIME-Version: 1.0
References: <1448679706-23771-1-git-send-email-chen_han_xiao@126.com>	<1448679706-23771-2-git-send-email-chen_han_xiao@126.com>
	<565C911F.8020605@redhat.com>
In-Reply-To: <565C911F.8020605@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qmp: add support for system_suspend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org


On 12/01/2015 02:10 AM, Eric Blake wrote:
> On 11/27/2015 08:01 PM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao@gmail.com>
>>
>> This patch add support for system_suspend qmp command.
>>
>> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>> ---
>>   qapi-schema.json |  9 +++++++++
>>   qmp-commands.hx  | 21 +++++++++++++++++++++
>>   qmp.c            |  5 +++++
>>   3 files changed, 35 insertions(+)
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 8b1a423..78bbb29 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -3971,3 +3971,12 @@
>>   ##
>>   { 'enum': 'ReplayMode',
>>     'data': [ 'none', 'record', 'play' ] }
>> +
>> +##
>> +# @system_suspend:
>> +#
>> +# Performs suspend operation of a guest.
>> +#
>> +# Since: 2.5
>> +##
>> +{ 'command': 'system_suspend' }
> You've missed 2.5; this should be since 2.6.  Also, new QMP commands
> should be named with '-' rather than '_'; so this should be
> 'system-suspend'.  (Yes, I know 'system_wakeup' already exists with the
> older spelling).
>
> How does this command differ from the existing ability to use
> qemu-guest-agent to request the guest put itself into suspend state?
>
I tried to add a suspend hmp command which not existed.
As your previous comment, I added this for qmp.
It duplicates with current qga commands though.

So we just need that hmp patch with a qmp_system_suspend.

Regards,
- Chen